Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weights #1355

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update weights #1355

merged 1 commit into from
Aug 14, 2024

Conversation

Chralt98
Copy link
Member

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Aug 13, 2024
@Chralt98 Chralt98 self-assigned this Aug 13, 2024
@maltekliemann
Copy link
Member

reject_market and report_market_... have lost dependency on parameters.

@maltekliemann
Copy link
Member

But this seems to happens all the time, and weights always fluctuate pretty wildly so...

@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 14, 2024
@Chralt98 Chralt98 merged commit 2df7347 into release-v0.5.4 Aug 14, 2024
21 checks passed
@Chralt98 Chralt98 deleted the release-v0.5.4-update-weights branch August 14, 2024 10:09
@Chralt98 Chralt98 added this to the v0.5.4 milestone Aug 21, 2024
mergify bot pushed a commit that referenced this pull request Aug 27, 2024
* Update versions to v0.5.4 (#1353)

* Update weights (#1355)

add weights

Co-authored-by: Your Name <you@example.com>

---------

Co-authored-by: Your Name <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants