Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold combo pallet #1367

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

maltekliemann
Copy link
Member

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Sep 23, 2024
@maltekliemann maltekliemann removed the s:review-needed The pull request requires reviews label Sep 23, 2024
@mergify mergify bot added the s:in-progress The pull requests is currently being worked on label Sep 23, 2024
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Sep 24, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop-combo-futarchy@d45ecf4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
zrml/combo/src/lib.rs 0.00% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             develop-combo-futarchy    #1367   +/-   ##
=========================================================
  Coverage                          ?   93.30%           
=========================================================
  Files                             ?      137           
  Lines                             ?    30418           
  Branches                          ?        0           
=========================================================
  Hits                              ?    28382           
  Misses                            ?     2036           
  Partials                          ?        0           
Flag Coverage Δ
tests 93.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltekliemann maltekliemann merged commit 2bd5e6c into develop-combo-futarchy Sep 24, 2024
19 checks passed
@maltekliemann maltekliemann deleted the mkl-combo-tokens-scaffold branch September 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:review-needed The pull request requires reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants