-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hadolint and Trivy Checks #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a fast scan-over opinion, proper review coming soon.
The major thing I see is that we do the checks when we want to publish the docker images. I assume an lint/security issue will stop the publishing of the image, won't it?
I think it would be better to check those before a PR is merged into main. In regards to that, it would be nice to triggers those checks only when relevant changes are made.
…can.yml success (#557)
Hello @sea212 can you please take a look at the changes I've made so far? And possibly take a look at the results of the job in https://github.com/zeitgeistpm/zeitgeist/actions/runs/4145477882/jobs/7169887429 |
This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏 |
This reverts commit b56966b.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 92.93% 92.94%
=======================================
Files 92 92
Lines 21589 21581 -8
=======================================
- Hits 20064 20058 -6
+ Misses 1525 1523 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
This reverts commit 209b601.
This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏 |
This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏 |
No description provided.