Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name the coordinate transformation matrices for different spaces #1042

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

engineer124
Copy link
Contributor

This PR is to keep the momentum going from our discussions in discord. This PR names:
mf_11D60 -> viewProjectionMtxF
mf_11DA0 -> billboardMtxF
unk_11DE0 -> billboardMtx
Further discussion and name suggestions are welcome. The most potential alternative offered is
mf_11D60 -> projectionMtxF
I also added a couple of comments in z_play to clarify when billboardMtxF is acting like a viewing matrix temporarily

Copy link
Collaborator

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audio_PlaySoundAtPosition evasion that's what this is

@fig02 fig02 merged commit eabc918 into zeldaret:master Nov 30, 2021
@engineer124 engineer124 deleted the coordinate-transformations branch December 2, 2021 10:10
louist103 pushed a commit to louist103/oot that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants