Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol cleanup 5 #1053

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Symbol cleanup 5 #1053

merged 1 commit into from
Dec 2, 2021

Conversation

Dragorn421
Copy link
Collaborator

#1050 but continued

Comment on lines +2356 to +2357
static void* sKokiriShopkeeperEyeTextures[] = {
gKokiriShopkeeperEyeDefaultTex,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does default mean in the context of an eye texture?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know (I wasn't the one who named this symbol) so I'm going to guess

I assume it may be because it's referenced in a dlist (gKokiriShopkeeperHeadDL) while the other two are not.

But it's kind of weird, that gKokiriShopkeeperEyeDefaultTex texture is used for two triangles and the "dynamic" eye texture for eight others

I assume they somehow didn't set those two triangles to be "segment 10 textured"


so it should probably be "open" instead of default

(interesting asset "bug" though)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i didnt realize it wasnt your name, in that case we can reevaluate later. thanks for taking a look at it though

@fig02 fig02 merged commit 8ff1f24 into zeldaret:master Dec 2, 2021
@Dragorn421 Dragorn421 mentioned this pull request Dec 7, 2021
@Dragorn421 Dragorn421 deleted the cleanup_symbols_5 branch December 12, 2021 14:09
louist103 pushed a commit to louist103/oot that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants