Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Player csMode enum #1462

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Conversation

engineer124
Copy link
Contributor

I've purposely left out filling out the enum values in OnePointCsFull.unk_01 because that seems to be a mix of player csModes, hud visibility, and something else. So I'll tackle that in a different PR

Copy link
Collaborator

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More enums!

Copy link
Collaborator

@fig02 fig02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the term cs mode may not stay around forever (iirc cdi didnt agree with it in his docs)
but, if it does stay, I think CS_MODE is better than CSMODE

but approving anyway cause its not something that needs to be figured out rn

@fig02 fig02 merged commit aa48c66 into zeldaret:master Dec 13, 2022
@engineer124 engineer124 deleted the player_csmode branch December 13, 2022 03:23
louist103 pushed a commit to louist103/oot that referenced this pull request Jan 3, 2023
* player csmode enum

* cleanup

* missed one, player2

* spell out enum name

* use CSMODE_MAX for data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants