Experiment: remove global.h dependency from sys_math, sys_math3d, z_lib #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a few more math functions scattered about so I've done those as well. Perhaps the headers can be better organized, but I'm pressed for time atm. |
cadmic
approved these changes
Jun 16, 2024
fig02
added
Needs first approval
Needs second approval
and removed
Needs first approval
labels
Thar0
suggested changes
Jun 19, 2024
include/libc/math.h
Outdated
| @@ -8,6 +8,7 @@ | |||
| #define MAXFLOAT 3.40282347e+38f | |||
| #define SHT_MAX 32767.0f | |||
| #define SHT_MINV (1.0f / SHT_MAX) | |||
| #define SQ(x) ((x)*(x)) | |||
There was a problem hiding this comment.
Since this is a standard C header, it should really only contain standard C macros. libultra probably should be changed so it doesn't use this and put it in z64math.h instead or something
src/code/sys_math3d_draw.c
Outdated
| @@ -0,0 +1,8 @@ | |||
| #include "global.h" | |||
| #include "terminal.h" | |||
Thar0
approved these changes
Jun 19, 2024
fig02
approved these changes
Jun 19, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if anyone is already working on this, or if it's what we want to do now, but I wanted to give it a shot anyway.
Anyway, quick summary of some significant changes:
Main goal was to just do sys_math.c/sys_math3d.c but a few other files got included in because of dependencies.
I split sys_math3d.c into a new sys_math3d_draw.c file, which eliminated a dependency on
PlayState. Might not be a real file split, but I don't anticipate reverting it to be too difficult to do, and it makes it far less likely to trigger bss issues.In z_lib.c/ichain.h I changed Actor_ProcessInitChain to take a void* actor instead of an Actor* actor, which removes the only dependency on
z64actor.h. I think it's a fair change since InitChain isn't operating on the Actor struct members.Made a bunch of new headers, hadn't really put much thought into the names or effort in cleaning it up.