BgSpot08Iceblock OK, some documentation #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some docs on the complicated function
fig02
reviewed
Feb 1, 2021
src/overlays/actors/ovl_Bg_Spot08_Iceblock/z_bg_spot08_iceblock.c
Outdated
Show resolved
Hide resolved
src/overlays/actors/ovl_Bg_Spot08_Iceblock/z_bg_spot08_iceblock.c
Outdated
Show resolved
Hide resolved
src/overlays/actors/ovl_Bg_Spot08_Iceblock/z_bg_spot08_iceblock.c
Outdated
Show resolved
Hide resolved
src/overlays/actors/ovl_Bg_Spot08_Iceblock/z_bg_spot08_iceblock.c
Outdated
Show resolved
Hide resolved
fig02
approved these changes
Feb 2, 2021
Roman971
approved these changes
Feb 2, 2021
mzxrules
pushed a commit
to mzxrules/oot
that referenced
this pull request
Jul 19, 2021
* OK, spec * all functions and variables named, some docs on the complicated function * delete asm * updated to reflect Actor changes * simplify one thing into a ternary * Address review comments
louist103
pushed a commit
to louist103/oot
that referenced
this pull request
Jan 3, 2023
* OK, spec * all functions and variables named, some docs on the complicated function * delete asm * updated to reflect Actor changes * simplify one thing into a ternary * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you know that the smallest size category of iceberg is "growlers"?
All functions and variables named (some more guesswork than others). Docs made for compound params, but nothing implemented; comments made where unclear. Attempt at documenting the rolling function, which feels unnecessarily obscure.
Can confirm that iceblocks induce just as much tilt in their code as in-game. Also admire the params-checking function, which has a jump table longer than its function body.