-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
padmgr and related #71
Conversation
silv3rwing07
commented
Apr 12, 2020
- padmgr all functions either matching or close
- Reasonable names for all padmgr functions (from Animal Forest) and many padmgr variables
- osReadMempak, osMempakAddrCRC, osMempakDataCRC decomped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job. just a few comments regarding style consistency with the rest of the codebase
Issues fixed and a few more names updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. I just have a bunch of comments regarding mostly style and cleanliness for some things.
All changes addressed except the comments I left above. |
All changes addressed. |