-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompile z_play.c and Match/Document some of z_view.c #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the last non matching in z_sample.c and update some game state functions.
fig02
reviewed
Apr 16, 2020
krimtonz
reviewed
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just some suggestions rather than fixes.
fig02
approved these changes
Apr 16, 2020
krimtonz
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes:
z_play.c
(including data/rodata/bss) with 7 non matchings left. I documented what I could but didn't spend too much time looking into other systems not well known yet, so a lot will still have to be documented at a later point. In particular, a lot of functions in this file deal with transition (fbdemo) and camera stuff, which have barely been touched so far.z_view.c
. I also changed some names and documented where I could while working on this file. But someone familiar with viewing/projection stuff (for example from OpenGL) would probably be able to document more of it.Other smaller changes:
z_sample.c
.SaveContext
struct and sub struct members to use camelCase instead of snake_case.QuestItem
enum and CHECK_QUEST_ITEM macro to access and check quest items.