Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompile z_play.c and Match/Document some of z_view.c #74

Merged
merged 5 commits into from
Apr 16, 2020

Conversation

Roman971
Copy link
Collaborator

Main Changes:

  • Decompiled z_play.c (including data/rodata/bss) with 7 non matchings left. I documented what I could but didn't spend too much time looking into other systems not well known yet, so a lot will still have to be documented at a later point. In particular, a lot of functions in this file deal with transition (fbdemo) and camera stuff, which have barely been touched so far.
  • Matched 4/5 of the remaining functions in z_view.c. I also changed some names and documented where I could while working on this file. But someone familiar with viewing/projection stuff (for example from OpenGL) would probably be able to document more of it.

Other smaller changes:

  • Matched the last function in z_sample.c.
  • Updated some game state function names to better fit certain patterns.
  • Fixed the SaveContext struct and sub struct members to use camelCase instead of snake_case.
  • Changed certain color structs to be unions so a whole word can be used to access the rgba color.
  • Added a QuestItem enum and CHECK_QUEST_ITEM macro to access and check quest items.
  • Fixed various minor issues throughout the codebase when I ran into them, as usual.

Also fix the last non matching in z_sample.c and update some game state functions.
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Show resolved Hide resolved
Copy link
Contributor

@krimtonz krimtonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just some suggestions rather than fixes.

src/code/z_play.c Show resolved Hide resolved
src/code/z_play.c Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
src/code/z_play.c Outdated Show resolved Hide resolved
@fig02 fig02 merged commit 262f6c5 into zeldaret:master Apr 16, 2020
@Roman971 Roman971 deleted the z_play branch April 20, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants