Decompiled ovl_En_Ma1 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshDuMan
reviewed
Apr 20, 2020
Roman971
reviewed
Apr 25, 2020
| s16 ret = 1; | ||
| switch (func_8010BDBC(&globalCtx->msgCtx)) { | ||
| case 2: | ||
| switch (this->actor.textId - 0x2041) { |
There was a problem hiding this comment.
This looks like it could just be a switch (this->actor.textId), with all cases being properly shifted (case 0x2041 instead of case 0, etc)
There was a problem hiding this comment.
I just tried this and it doesn't seem to work.
Co-Authored-By: Roman971 <32455037+Roman971@users.noreply.github.com>
Merged
Roman971
approved these changes
Apr 26, 2020
fig02
reviewed
Apr 26, 2020
| if (this->unk_1E8.unk_00 == 0) { | ||
| if (this->unk_1E0 != 0) { | ||
| this->unk_1E0 = 0; | ||
| func_800F6584(0, this); |
There was a problem hiding this comment.
this function appears to be called by en_ma1, 2 and 3. I would make this &this->actor, and below where it is used again
There was a problem hiding this comment.
It actually doesn't even take that other arg, which I'll fix in Ma2 after this is merged
fig02
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a new script, gen_mips_to_c_context.py. You feed it a .s file and it will create a context file for mips_to_c at build/ctx.c . Only tested so far on actors.