Finished code_801031F0.c, guPosition.c, guLookAtHilite.c #84
Conversation
src/code/irqmgr.c
Outdated
| @@ -142,7 +142,7 @@ void IrqMgr_HandlePRENMI450(IrqMgr* this) { | |||
| void IrqMgr_HandlePRENMI480(IrqMgr* this) { | |||
| u32 ret; | |||
| osSetTimer(&this->timer, OS_USEC_TO_CYCLES(20000), 0ull, &this->queue, (OSMesg)PRENMI500_MSG); | |||
| ret = func_801031F0(); // osAfterPreNMI | |||
| ret = osAfterPreNMI(); // osAfterPreNMI | |||
There was a problem hiding this comment.
now that its named proper you can remove this comment
src/libultra_code/code_801031F0.c
Outdated
| /** | ||
| * osContStartQuery: | ||
| * Starts to read the values for SI device status and type which are connected to the controller port and joyport | ||
| *connector. |
There was a problem hiding this comment.
formatting thing, just a space after the star. Also throughout the codebase Im pretty sure we dont have a linebreak between block comments and the function itself so that would be nice to keep consistent as well
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| // TODO: rename these | |||
| // SM64 OOT | |||
| #define guMtxIdentF func_80101B40 | |||
| #define guMtxIdentF guMtxIdentF | |||
There was a problem hiding this comment.
are these defines needed now that they are named properly? no clue what the purpose of them is. Also if the other one in here is a correct name why not rename that too I guess?
There was a problem hiding this comment.
That was there before I even started these files. I’ll fix all this when I get the chance today :)
|
We deliberately shut down argument listings in a different PR so I think it makes sense to keep it consistent |
|
Removed argument listing |
Also added documentation to some of these functions based on SDK docs.
Left code_801031F0.c as the name it is, didn't know what to call it.