Make a XML for ganon_mant #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thar0
reviewed
Sep 12, 2021
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
Thar0
approved these changes
Sep 12, 2021
fig02
approved these changes
Sep 12, 2021
Dragorn421
reviewed
Sep 12, 2021
|
|
||
| <DList Name="gMantTexDL" Offset="0x3318"/> | ||
|
|
||
| <!-- ! @bug gMantUnusedTex is 32x32 not 32x64, however this dlist is unused --> |
There was a problem hiding this comment.
Is this the right way to document a bug in assets? Or just lack of a better option
There was a problem hiding this comment.
when we move toward committing the c files it will be easier to just put it right in the file. but for now this is all we got i guess
| #define MANT_TEX_WIDTH 32 | ||
| #define MANT_TEX_HEIGHT 64 | ||
|
|
||
| static u64 sForceDmaAlignment = 0; |
There was a problem hiding this comment.
I dont think this should mention anything "dma" related, this "boundary" is inside of a file as far as the dma table knows
Maybe just sForceAlignment idk
There was a problem hiding this comment.
I just moved over the already existing variable from the _gfx.c file.
But you are right, I'll rename it
Dragorn421
approved these changes
Sep 13, 2021
Roman971
approved these changes
Sep 18, 2021
louist103
pushed a commit
to louist103/oot
that referenced
this pull request
Jan 3, 2023
* Make a XML for ganon_mant * cleanup * Apply suggestions from code review Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> * sForceAlignment Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just reused the names from
ovl_en_ganon_mant_gfx.c