Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terminal): repeat retry screen instruction sending during stdin cache replay (cont) #3570

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

manueldeprada
Copy link
Contributor

We come from #3506

The sleeping time has been set to 5ms, as suggested. As noted in #3506 (comment), entering the while loop does not significantly impact performance.

@manueldeprada
Copy link
Contributor Author

bumping this!!

@imsnif
Copy link
Member

imsnif commented Sep 30, 2024

Not forgotten :) Thanks for the reminder. Will get to it before the release, it's just one item out of about 50.

@imsnif
Copy link
Member

imsnif commented Oct 10, 2024

Hey, this looks good to me. Want to run cargo fmt so that CI passes and then I'll merge?

@manueldeprada
Copy link
Contributor Author

manueldeprada commented Oct 13, 2024

Hey, this looks good to me. Want to run cargo fmt so that CI passes and then I'll merge?

done!!

edit: didnt work for some reason. I reran it from zellij-server and forced push again

@imsnif
Copy link
Member

imsnif commented Oct 14, 2024

Running cargo fmt from the project root should take care of this. It might be an issue of a rust version - in that case rustup update and then cargo fmt might do the trick.

@manueldeprada
Copy link
Contributor Author

Running cargo fmt from the project root should take care of this. It might be an issue of a rust version - in that case rustup update and then cargo fmt might do the trick.

done! hope it passes now

@imsnif imsnif merged commit f968736 into zellij-org:main Oct 16, 2024
6 checks passed
@imsnif
Copy link
Member

imsnif commented Oct 16, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants