Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Feature/switch #127

Closed
wants to merge 2 commits into from
Closed

Conversation

keeper-vit
Copy link
Contributor

I added a switch for close and open panel.
I think with this changes you can close issue #111.

@coss
Copy link
Contributor

coss commented Oct 31, 2013

Sorry, but this looks just like a more fancy way to hide/show the toolbar itself (~4.5 Kb extra per Request). This is actually unrelated to #111, because hiding to toolbar was never the problem.

The problem is that you have to hover over icons in order to show details/activate the collector panel, however the CSS pseudo class :hover won't work on touchscreen devices such as Smartphones and Touchpads.

@keeper-vit
Copy link
Contributor Author

Maybe these symbols ✖ and ▣ can be used to hide/show actions.

@keeper-vit keeper-vit closed this Nov 1, 2013
@keeper-vit keeper-vit reopened this Nov 1, 2013
@Ocramius
Copy link
Member

@coss I'm gonna merge this - the toolbar is not supposed to be included for touch devices anyway, as it is a debug tool supposed to be used only while developing (on a workstation). The additional 4.5k are also not a big deal here.

@Ocramius Ocramius closed this in 1a0e780 Apr 16, 2014
@Ocramius Ocramius self-assigned this Apr 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants