Fixes #216 remove \Exception type hint

[samsonasik]

No description provided.

[Ocramius]

@samsonasik can you verify it with a test? Doing something like following should suffice:

try {
    (new \stdClass)->iDoNotExist();
} catch (\Throwable $exception) { 
    $serializable = new SerializableException($exception);
   // assert here
}

// fail if no $exception thrown

[samsonasik]

@Ocramius (new \stdClass)->iDoNotExist(); will result Error in php7

[Ocramius]

It will be a throwable instance

[samsonasik]

@Ocramius I got this error:

...PHP Fatal error:  Uncaught TypeError: Argument 1 passed to ZendDeveloperTools\Exception\SerializableException::__construct() must be an instance of Exception, instance of Error given,

[Ocramius]

@samsonasik https://3v4l.org/gS75T

[samsonasik]

@Ocramius done ;), tests added, should be ok now ;)

[Ocramius]

Test requires PHP 7 - you can use the PHPUnit annotation for that

[samsonasik]

@Ocramius tests updated. Travis now green \m/

[snapshotpl]

Anyone can merge it? It fail on my php7 dev machine ;(

[DannyvdSluijs]

I would also like this to be merged.

[ikovalyov]

+1 please merge

[vladas]

@samsonasik Is there any reason you removed the type hinting? Exception and Error are instances of Throwable. In my mind it should have been enough to replace \Exception with \Throwable.

[samsonasik]

\Throwable only works with php7, we use it in php ^5.6

[DannyvdSluijs]

@vladas \Throwable is only availible from PHP7. It would break any compatibility with 5.X

[vladas]

Ok, fair enough.

[MatthiasKuehneEllerhold]

Any news on this PR?

[weierophinney]

Thanks, @samsonasik