Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Changing 'continue' to 'break' inside switches to avoid PHP 7.3 warnings #253

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Changing 'continue' to 'break' inside switches to avoid PHP 7.3 warnings #253

merged 1 commit into from
Mar 5, 2019

Conversation

vcampitelli
Copy link
Contributor

When using continue inside switch statements, PHP 7.3 issues the following warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

This commit replaces all these occurrences of continue to break (no continue 2 was needed).

@michalbundyra michalbundyra mentioned this pull request Dec 15, 2018
Closed
@Ocramius Ocramius mentioned this pull request Jan 15, 2019
Closed
@GodLesZ
Copy link

GodLesZ commented Mar 1, 2019

@weierophinney hard waiting for this to get a project to PHP 7.3 without suppressing warnings 👍

@weierophinney weierophinney mentioned this pull request Mar 5, 2019
Closed
15 tasks
@weierophinney weierophinney merged commit b06a841 into zendframework:master Mar 5, 2019
weierophinney added a commit that referenced this pull request Mar 5, 2019
@weierophinney
docs: adds CHANGELOG entry for #253 and #254
86cfe77
weierophinney added a commit that referenced this pull request Mar 5, 2019
@weierophinney
Merge branch 'hotfix/php-7.3-support' into develop
88ab794 
Forward port #253
Forward port #254

Conflicts:
	CHANGELOG.md
@pedes42 pedes42 mentioned this pull request Mar 27, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcampitelli @GodLesZ @weierophinney