Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sse ignore timeout #2041

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

chenquan
Copy link
Member

@chenquan chenquan commented Jun 22, 2022

@lxkaka
Copy link

lxkaka commented May 12, 2023

why this mr can not be merged

@linganmin
Copy link
Contributor

linganmin commented Jun 22, 2023

why this mr can not be merged ?

If timeouthandler is not ignored, implementing SSE will report the following error:

2023/06/22 21:46:03 http: superfluous response.WriteHeader call from github.com/zeromicro/go-zero/rest/internal/response.(*WithCodeResponseWriter).WriteHeader (withcoderesponsewriter.go:45)

Or whether the specified route can be implemented to ignore timeouthandler ?

@waltcow
Copy link

waltcow commented Jun 29, 2023

why this mr can not be merged

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f1d4c6) 94.44% compared to head (29aa019) 94.44%.

Additional details and impacted files
Files Coverage Δ
rest/handler/timeouthandler.go 97.81% <100.00%> (+0.03%) ⬆️

@kevwan kevwan added this pull request to the merge queue Feb 17, 2024
Merged via the queue into zeromicro:master with commit 28cb2c5 Feb 17, 2024
6 checks passed
@chenquan chenquan deleted the feat/sse-ignore-timeout branch February 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Server-Sent-Events?
5 participants