Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mapping): call fillSliceValue panic if the value is nil #3839

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix(mapping): call fillSliceValue panic if the value is nil #3839

merged 1 commit into from
Jan 13, 2024

Conversation

wuqinqiang
Copy link
Contributor

@wuqinqiang wuqinqiang commented Jan 12, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81d72b5) 94.67% compared to head (11259d8) 94.66%.

Additional details and impacted files
Files Coverage Δ
core/mapping/unmarshaler.go 96.45% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@kevwan kevwan added this pull request to the merge queue Jan 13, 2024
Merged via the queue into zeromicro:master with commit 0441f84 Jan 13, 2024
6 checks passed
@kevwan kevwan mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wuqinqiang @kevwan