Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support http stream response #4055

Merged
merged 1 commit into from
Apr 9, 2024
Merged

feat: support http stream response #4055

merged 1 commit into from
Apr 9, 2024

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Apr 9, 2024

  1. support httpx.Stream method
  2. set timeout to 0 to use httpx.Stream if multiple writes cannot complete within timeout

This was linked to issues Apr 9, 2024
how can i handle streaming response by gozero #3980
Closed
How to use SSE Response with go-zero? #3967
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (8690859) to head (02c483c).
Report is 3 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
rest/httpx/responses.go 100.00% <100.00%> (ø)

... and 254 files with indirect coverage changes

chenquan
chenquan approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@chenquan chenquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit 3866b57 into zeromicro:master Apr 9, 2024
6 checks passed
@kevwan kevwan deleted the feat/httpx-stream branch April 9, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenquan chenquan chenquan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how can i handle streaming response by gozero How to use SSE Response with go-zero?
2 participants
@kevwan @chenquan