Problem: self tests can be improved #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Created three new self tests for specific API sets: 1) mlm_stream_api 2) mlm_service_api 3) mlm_services_api The difference between tests 2 and 3 is that mlm_service_api shows how to use the service APIs with one requester, one worker, while that mlm_services_api shows how to use the service API with two requesters and two workers. Also greatly increased the number of asserts in existing tests, making sure no returned code goes without checking. I believe that to be important in self tests. Hopefully I correctly followed the unwritten rules of formatting required such as space before the parenthesis in function calls and no camel case of variable names. By the way, I even fixed this for some existing code. If any of this code should be generated, I was not able to find the source, so I modified the .h/.c files directly. Sorry if this is a mistake. If so, please let me know what are the xml/gsl files that I should have applied my changes instead and I will modify them. The plan is to write another test to focus on the mailbox API only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Created three new self tests for specific API sets:
The difference between tests 2 and 3 is that mlm_service_api shows
how to use the service APIs with one requester, one worker, while that
mlm_services_api shows how to use the service API with two requesters
and two workers.
Also greatly increased the number of asserts in existing tests, making
sure no returned code goes without checking.
I believe that to be important in self tests.
Hopefully I correctly followed the unwritten rules of formatting required
such as space before the parenthesis in function calls and no camel case
of variable names. By the way, I even fixed this for some existing code.
If any of this code should be generated, I was not able to find the source,
so I modified the .h/.c files directly. Sorry if this is a mistake.
If so, please let me know what are the xml/gsl files that I should have
applied my changes instead and I will modify them.
The plan is to write another test to focus on the mailbox API only.