Skip to content

Commit

Permalink
Removing Firefox profile cleaning step in .NET bindings
Browse files Browse the repository at this point in the history
Firefox used to require launching to clean up potential issues with the
anonymous temporary profile that we use with the driver. This is no longer
the case.
  • Loading branch information
jimevans committed May 22, 2015
1 parent 144f5ee commit 04e6815
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
22 changes: 0 additions & 22 deletions dotnet/src/webdriver/Firefox/FirefoxBinary.cs
Original file line number Diff line number Diff line change
Expand Up @@ -219,28 +219,6 @@ public void WaitForProcessExit()
this.process.WaitForExit();
}

/// <summary>
/// Initializes the binary with the specified profile.
/// </summary>
/// <param name="profile">The <see cref="FirefoxProfile"/> to use to initialize the binary.</param>
public void Clean(FirefoxProfile profile)
{
if (profile == null)
{
throw new ArgumentNullException("profile", "profile cannot be null");
}

this.StartProfile(profile, "-silent");
try
{
this.WaitForProcessExit();
}
catch (ThreadInterruptedException e)
{
throw new WebDriverException("Thread was interrupted", e);
}
}

/// <summary>
/// Stops the execution of this <see cref="FirefoxBinary"/>, terminating the process if necessary.
/// </summary>
Expand Down
1 change: 0 additions & 1 deletion dotnet/src/webdriver/Firefox/FirefoxDriverServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public void Start()
int portToUse = DetermineNextFreePort(this.host, this.profile.Port);
this.profile.Port = portToUse;
this.profile.WriteToDisk();
this.process.Clean(this.profile);
this.process.StartProfile(this.profile, new string[] { "-foreground" });

this.SetAddress(portToUse);
Expand Down

0 comments on commit 04e6815

Please sign in to comment.