Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing english translations #443

Merged
merged 6 commits into from
Aug 6, 2018
Merged

Conversation

venkat20390
Copy link
Contributor

I have added the missing English translations for the project

@@ -32,6 +32,8 @@
<string name="error_file_type">Unsupported file type</string>
<string name="error_type_conflict">Can\'t select images and videos at the same time</string>
<string name="error_no_video_activity">No App found supporting video preview</string>
<string name="error_over_original_size">Can\'t select the images larger than %1$d MB</string>
<string name="error_over_original_count">Can\'t select more than %1$d images or %2$d MB size</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry , error_over_original_count 's translate is not right .
In fact ,it means the selected image over the size , original checkbox will be canceled .please check your commit .

@venkat20390
Copy link
Contributor Author

venkat20390 commented Jul 22, 2018

@REBOOTERS I have changed it in the recent commit. Please let me know if you need me to use better phrases in the translation.

@@ -32,6 +32,8 @@
<string name="error_file_type">Unsupported file type</string>
<string name="error_type_conflict">Can\'t select images and videos at the same time</string>
<string name="error_no_video_activity">No App found supporting video preview</string>
<string name="error_over_original_size">Can\'t select the images larger than %1$d MB</string>
<string name="error_over_original_count">%1$d images over %2$d MB. Selection of those images will be removed</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en , you can try this feature by run the sample .In fact , when you checked original checkbox ,it will just uncheck the checkbox after the dialog dimissed .so "removed " may not be a apposite word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of "Original" option in the selection screen?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let user decide weather use original photo in next step or not .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see only the URI and File Path on both Original radio button checked and unchecked cases. What do you mean by next step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great, if you tell me simple use case of the Original option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next step means you press sure button ,to use the selected photo in your own project.

case 1: you check original-checkbox, then you select a photo which oversize the original maxSize limit ,then the origin-checkbox will unchecked and show a dialog.

case 2: you selected some photos , if one of those photo's size is oversized ,then if you want to check original-checkbox, it will fail with a dailog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By use case, i mean what is the difference during the selection when users checked and unchecked?

After pressing the sure button, whether the Original is checked or unchecked during the selection, i just get the media files URL and URI that's it. What is the purpose of Original option?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matisse.obtainOriginalState(Intent data) can get Original option info from user.

@REBOOTERS REBOOTERS merged commit 71a4719 into zhihu:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants