Skip to content

Commit

Permalink
chacha20,poly1305,chacha20poly1305: set consistent build tags
Browse files Browse the repository at this point in the history
appengine was only necessary for the legacy system based on Go 1.9, drop
that. Add purego tags instead. Remove redundant architecture tags.

Change-Id: Ib1f65a4837511e63e08c1aa43163a79cfe868e0c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/215498
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
  • Loading branch information
FiloSottile committed Feb 21, 2020
1 parent eddbd5d commit 2aa609c
Show file tree
Hide file tree
Showing 19 changed files with 19 additions and 21 deletions.
3 changes: 1 addition & 2 deletions chacha20/chacha_arm64.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build go1.11
// +build !gccgo,!appengine
// +build go1.11,!gccgo,!purego

package chacha20

Expand Down
3 changes: 1 addition & 2 deletions chacha20/chacha_arm64.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build go1.11
// +build !gccgo,!appengine
// +build go1.11,!gccgo,!purego

#include "textflag.h"

Expand Down
2 changes: 1 addition & 1 deletion chacha20/chacha_noasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build !arm64,!s390x,!ppc64le arm64,!go1.11 gccgo appengine
// +build !arm64,!s390x,!ppc64le arm64,!go1.11 gccgo purego

package chacha20

Expand Down
2 changes: 1 addition & 1 deletion chacha20/chacha_ppc64le.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build !gccgo,!appengine
// +build !gccgo,!purego

package chacha20

Expand Down
2 changes: 1 addition & 1 deletion chacha20/chacha_ppc64le.s
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// The differences in this and the original implementation are
// due to the calling conventions and initialization of constants.

// +build !gccgo,!appengine
// +build !gccgo,!purego

#include "textflag.h"

Expand Down
2 changes: 1 addition & 1 deletion chacha20/chacha_s390x.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build !gccgo,!appengine
// +build !gccgo,!purego

package chacha20

Expand Down
2 changes: 1 addition & 1 deletion chacha20/chacha_s390x.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build !gccgo,!appengine
// +build !gccgo,!purego

#include "go_asm.h"
#include "textflag.h"
Expand Down
2 changes: 1 addition & 1 deletion chacha20poly1305/chacha20poly1305_amd64.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build go1.7,amd64,!gccgo,!appengine
// +build !gccgo,!purego

package chacha20poly1305

Expand Down
2 changes: 1 addition & 1 deletion chacha20poly1305/chacha20poly1305_amd64.s
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

// This file was originally from https://golang.org/cl/24717 by Vlad Krasnov of CloudFlare.

// +build go1.7,amd64,!gccgo,!appengine
// +build !gccgo,!purego

#include "textflag.h"
// General register allocation
Expand Down
2 changes: 1 addition & 1 deletion chacha20poly1305/chacha20poly1305_noasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build !amd64 !go1.7 gccgo appengine
// +build !amd64 gccgo purego

package chacha20poly1305

Expand Down
2 changes: 1 addition & 1 deletion poly1305/mac_noasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build !amd64,!ppc64le gccgo appengine
// +build !amd64,!ppc64le gccgo purego

package poly1305

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_amd64.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build amd64,!gccgo,!appengine
// +build !gccgo,!purego

package poly1305

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_amd64.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build amd64,!gccgo,!appengine
// +build !gccgo,!purego

#include "textflag.h"

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_noasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build s390x,!go1.11 !amd64,!s390x,!ppc64le gccgo appengine nacl
// +build s390x,!go1.11 !amd64,!s390x,!ppc64le gccgo purego

package poly1305

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_ppc64le.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build ppc64le,!gccgo,!appengine
// +build !gccgo,!purego

package poly1305

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_ppc64le.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build ppc64le,!gccgo,!appengine
// +build !gccgo,!purego

#include "textflag.h"

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_s390x.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build s390x,go1.11,!gccgo,!appengine
// +build go1.11,!gccgo,!purego

package poly1305

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_s390x.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build s390x,go1.11,!gccgo,!appengine
// +build go1.11,!gccgo,!purego

#include "textflag.h"

Expand Down
2 changes: 1 addition & 1 deletion poly1305/sum_vmsl_s390x.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// +build s390x,go1.11,!gccgo,!appengine
// +build go1.11,!gccgo,!purego

#include "textflag.h"

Expand Down

0 comments on commit 2aa609c

Please sign in to comment.