Change some tests to use Alert#accept() instead of Alert#dismiss() to…

… get rid of alert dialogs. This is a workaround to ChromeDriver issue 764: https://code.google.com/p/chromedriver/issues/detail?id=764
zhoubaozhou · May 6, 2014 · fdf34c6 · fdf34c6
1 parent 111a303
commit fdf34c6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/java/client/test/org/openqa/selenium/AlertsTest.java b/java/client/test/org/openqa/selenium/AlertsTest.java
@@ -122,7 +122,7 @@ public void testShouldAllowUsersToDismissAnAlertManually() {
     wait.until(presenceOfElementLocated(By.id("alert"))).click();
 
     Alert alert =  wait.until(alertIsPresent());
-    alert.dismiss();
+    alert.accept();
 
     // If we can perform any action, we're good to go
     assertEquals("Testing Alerts", driver.getTitle());
@@ -209,7 +209,7 @@ public void testAlertShouldNotAllowAdditionalCommandsIfDismissed() {
     driver.findElement(By.id("alert")).click();
 
     Alert alert = wait.until(alertIsPresent());
-    alert.dismiss();
+    alert.accept();
 
     try {
       alert.getText();

diff --git a/java/client/test/org/openqa/selenium/FormHandlingTest.java b/java/client/test/org/openqa/selenium/FormHandlingTest.java
@@ -287,7 +287,7 @@ public void handleFormWithJavascriptAction() {
     element.submit();
     Alert alert = driver.switchTo().alert();
     String text = alert.getText();
-    alert.dismiss();
+    alert.accept();
 
     assertEquals("Tasty cheese", text);
   }