Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint issues #212

Closed
wants to merge 2 commits into from
Closed

Conversation

adonespitogo
Copy link

When I first forked the repo and run test, I get this minor errors:

[adonesp@archlinux mocha-webpack]$ npm run lint

> mocha-webpack@1.1.0 lint /home/adonesp/Projects/mocha-webpack
> eslint src test bin


/home/adonesp/Projects/mocha-webpack/src/MochaWebpack.js
  29:35  error  Block must not be padded by blank lines  padded-blocks

/home/adonesp/Projects/mocha-webpack/src/runner/TestRunner.js
  37:54  error  Block must not be padded by blank lines  padded-blocks

/home/adonesp/Projects/mocha-webpack/src/runner/testRunnerReporter.js
  24:16  error  Block must not be padded by blank lines  padded-blocks

/home/adonesp/Projects/mocha-webpack/src/util/glob.js
  13:1  error  Expected indentation of 0 spaces but found 2  indent

/home/adonesp/Projects/mocha-webpack/src/webpack/loader/entryLoader.js
   6:19  error  Block must not be padded by blank lines  padded-blocks
  28:1   error  Block must not be padded by blank lines  padded-blocks

/home/adonesp/Projects/mocha-webpack/src/webpack/util/getAffectedModuleIds.js
  19:34  error  Multiple spaces found before '// eslint-disa...'  no-multi-spaces

/home/adonesp/Projects/mocha-webpack/src/webpack/util/getBuildStats.js
  36:1  error  Expected indentation of 6 spaces but found 8  indent

✖ 8 problems (8 errors, 0 warnings)
  8 errors, 0 warnings potentially fixable with the `--fix` option.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! mocha-webpack@1.1.0 lint: `eslint src test bin`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the mocha-webpack@1.1.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/adonesp/.npm/_logs/2018-03-18T14_38_17_941Z-debug.log

Upgraded eslint and babel-eslint to fix eslint/eslint#2224
as suggested at babel/babel-eslint#487 (comment)

@codecov-io
Copy link

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #212   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files          28      28           
  Lines         751     751           
======================================
  Hits          727     727           
  Misses         24      24
Impacted Files Coverage Δ
src/runner/TestRunner.js 100% <ø> (ø) ⬆️
src/MochaWebpack.js 100% <ø> (ø) ⬆️
src/runner/testRunnerReporter.js 95.45% <ø> (ø) ⬆️
src/webpack/loader/entryLoader.js 100% <ø> (ø) ⬆️
src/util/glob.js 100% <100%> (ø) ⬆️
src/webpack/util/getBuildStats.js 100% <100%> (ø) ⬆️
src/webpack/util/getAffectedModuleIds.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1929d...b6ca016. Read the comment docs.

@zinserjan
Copy link
Owner

Thanks for working on this!
Unfortunately @astorije fixed the eslint issues already on another branch. That's why I'm gonna close this one.

@zinserjan zinserjan closed this Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block must not be padded by blank lines.
3 participants