Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve nav loading in content #10

Merged
merged 3 commits into from
May 21, 2024
Merged

feat: improve nav loading in content #10

merged 3 commits into from
May 21, 2024

Conversation

itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented May 21, 2024 •
edited
Loading

What 💻

  • Improve nav data fetching
  • Adjust metadata for tutorials by moving into _diry.yml
  • Update SEO

Why ✋

  • Nav was slow because I was manually fetching nav data on each page.
    • Instead fetch the already loaded nav data from app.vue and re-use that in pages
  • _dir.yml is the standard way of handling metadata for routes in Nuxt Content

@itsacoyote itsacoyote requested a review from uF4No May 21, 2024 16:23
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit c7e73d7):

https://community-cookbook-staging--pr10-improvements-rc05a8wi.web.app

(expires Tue, 28 May 2024 18:40:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

@itsacoyote itsacoyote merged commit 7dca130 into staging May 21, 2024
8 checks passed
@itsacoyote itsacoyote deleted the improvements branch June 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uF4No uF4No Awaiting requested review from uF4No

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itsacoyote