Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README-FR.md #19

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Create README-FR.md #19

merged 3 commits into from
Oct 12, 2023

Conversation

MarcVlad
Copy link
Contributor

Add a French version of ZK Credo.

@0xsisyfos
Copy link
Collaborator

Hello MarcVlad,

First of all, thank you very much for contributing to the ZK Credo by translating it. We appreciate it greatly, and the community will benefit immensely from your work.

To ensure the quality and consistency of the ZK Credo, we asked a third party to review the translation. We invite you to consider their feedback and make the necessary changes before we accept the PR. Please find the suggestions below:

A. You translated if you insist to si vous insistez. We can delete it in French, as it is a it strange in our language.

B. Consider changing avec consistance to avec cohérence. Reason: Accuracy, Incorrect Meaning or Numbers (Minor).

C. To the verb quitter you should modify it to quitter le réseau (verb transitiv) (original: fork away from the network)

D. Elle simplifie l'alambiqué, elle transforme des opérations compliquées en quelques clics to Elle simplifie l'alambiqué, transformant des opérations compliquées en quelques clics.

E. économie libre de l'Internet and Internet de la valeur to Internet de la valeur

F. You forgot to translate or control their assets to ou contrôler leurs actifs

G. After auto-propriété numérique You are missing the ..

Let me know if you have any questions.
Thank you very much (Merci beaucoup!) again for your contribution.

A. You translated if you insist to si vous insistez. We can delete it in French, as it is a it strange in our language.

B. Consider changing avec consistance to avec cohérence. Reason: Accuracy, Incorrect Meaning or Numbers (Minor).

C. To the verb quitter you should modify it to quitter le réseau (verb transitiv) (original: fork away from the network)

D. Elle simplifie l'alambiqué, elle transforme des opérations compliquées en quelques clics to Elle simplifie l'alambiqué, transformant des opérations compliquées en quelques clics.

E. économie libre de l'Internet and Internet de la valeur to Internet de la valeur

F. You forgot to translate or control their assets to ou contrôler leurs actifs

G. After auto-propriété numérique You are missing the ..
@MarcVlad
Copy link
Contributor Author

Here is the corrected version incorporating the requested modifications.

Merci 0xsisyfos and the anonymous third party for your help in making sure the French ZK Credo translation is of the highest quality!

Meilleures salutations!

@0xsisyfos 0xsisyfos merged commit e4fb9ed into zksync:main Oct 12, 2023
@0xsisyfos
Copy link
Collaborator

Thank you very much!
You can now mint a GitPOAP (https://www.gitpoap.io/gp/1079) as a contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants