Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README_TR #48

Merged
merged 5 commits into from
Nov 18, 2023
Merged

Create README_TR #48

merged 5 commits into from
Nov 18, 2023

Conversation

zkCan
Copy link
Contributor

@zkCan zkCan commented Nov 7, 2023

ZK Credo Türkçe Çeviri
ZK Credo Turkish Translation

@zkCan zkCan closed this Nov 10, 2023
@zkCan zkCan reopened this Nov 10, 2023
@0xsisyfos
Copy link
Collaborator

Hello @zkCan

First of all, thank you very much for contributing to the ZK Credo by translating it. We appreciate it greatly, and the community will benefit immensely from your work.

To ensure the quality and consistency of the ZK Credo, we asked a third party to review the translation. We invite you to consider their feedback and make the necessary changes before we accept the PR. Please find the suggestions below. They are suggestions to changes from A (current version) to B (suggested version):

  • işlemleri to ticari işlemleri
  • mekanizasyon to makineleşme
  • güvenme, doğrulama to güvenme, doğrula
  • savunmamız ve savunmamız to ileri sürmemiz ve savunmamız
  • Sanür Direnci to Sansür Direnci
  • ileri. to İleri.

Let us know what you think of these suggestions,
Best

@zkCan
Copy link
Contributor Author

zkCan commented Nov 18, 2023

I made changes after feedback I think translation is now complated. Only one feedback "mekanizasyon to makineleşme" for sentence integrity i changed to "mekanizasyon to makineleşmenin"

@0xsisyfos 0xsisyfos merged commit f51ee1f into zksync:main Nov 18, 2023
@0xsisyfos
Copy link
Collaborator

Thank you! That is great :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants