-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards compatibility issue with minizip-ng #747
Labels
Comments
Feel free to submit a PR. |
Ok, I wanted to see what you would say before trying to come up with something. |
brad0
added a commit
to brad0/minizip-ng
that referenced
this issue
Dec 16, 2023
Building a project that had an internal copy of minizip 1.x, but prefering an external library, with minizip 4.x showed that the compat layer was not exposing some constants from zlib that minizip 1.x headers did.
brad0
added a commit
to brad0/minizip-ng
that referenced
this issue
Dec 16, 2023
Building a project that had an internal copy of minizip 1.x, but preferring an external library, with minizip 4.x showed that the compat layer was not exposing some constants from zlib that minizip 1.x headers did.
brad0
added a commit
to brad0/minizip-ng
that referenced
this issue
Dec 16, 2023
Building a project that had an internal copy of minizip 1.x, but preferring an external library, with minizip 4.x showed that the compat layer was not exposing some constants from zlib that minizip 1.x headers did.
brad0
added a commit
to brad0/minizip-ng
that referenced
this issue
Dec 18, 2023
Building a project that had an internal copy of minizip 1.x, but preferring an external library, with minizip 4.x showed that the compat layer was not exposing some constants from zlib that minizip 1.x headers did.
brad0
added a commit
to brad0/minizip-ng
that referenced
this issue
Dec 22, 2023
Building a project that had an internal copy of minizip 1.x, but preferring an external library, with minizip 4.x showed that the compat layer was not exposing some constants from zlib that minizip 1.x headers did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have run into a project that has an embedded copy of minizip 1.x. It tries to use an external copy if found but fails to build with minizip 4.x.
It uses the zip.h / unzip.h headers which in minizip 4.x I see are empty and just use mz_compat.h.
The build trips up trying to find the constants Z_BEST_COMPRESSION and Z_DEFAULT_STRATEGY.
The minizip 1.x zip.h / unzip.h headers include the zlib.h header, the minizip 4.x headers do not.
I would expect that the minizip 4.x headers would provide the constants if they're part of the minizip API.
The text was updated successfully, but these errors were encountered: