Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issue with zipOpenNewFileInZip64 #787

Closed
cameronwhite opened this issue Jun 11, 2024 · 1 comment
Closed

Compatibility issue with zipOpenNewFileInZip64 #787

cameronwhite opened this issue Jun 11, 2024 · 1 comment
Labels
compatibility Backwards compatibility

Comments

@cameronwhite
Copy link

Related to #400, it seems that the signature of zipOpenNewFileInZip_64() is incorrect and should have been zipOpenNewFileInZip64() (without the underscore). I ran into this after investigating some compilation issues reported by a user on Fedora with minizip-ng (powertab/powertabeditor#478)

For reference in the original minizip: https://github.com/madler/zlib/blob/develop/contrib/minizip/zip.h#L163
vs https://github.com/zlib-ng/minizip-ng/blob/develop/mz_compat.h#L177
nmoinvaz added a commit that referenced this issue Jun 15, 2024
@nmoinvaz
Added definition for zipOpenNewFileInZip64 for backwards compat #787
bfc8f6c
@nmoinvaz nmoinvaz added the compatibility Backwards compatibility label Jun 15, 2024
@nmoinvaz
Copy link
Member

I have added a shim for it. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cameronwhite @nmoinvaz