Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #2

Open
yfdyh000 opened this issue Nov 27, 2017 · 77 comments
Open

Suggestions #2

yfdyh000 opened this issue Nov 27, 2017 · 77 comments

Comments

@yfdyh000
Copy link
Contributor

  1. "extDescription" to "Sidebar for Chromium and Firefox" or like "Sidebar panels".
  2. No option to disable the startpage?
  3. RSS Panel work?
  4. Some options (input-number) and the search engine list is covered in 1366*768, and more serious if adjusted layout.css.devPixelsPerPx.
  5. No context menu support. See also https://github.com/eoger/tabcenter-redux.
  6. The bookmark panel is stuck when there are 10k bookmarks.
@zluca
Copy link
Owner

zluca commented Nov 27, 2017

  1. Agree
  2. Well, for now startpage hardcoded in the manifest and can not be disabled. I had experiments with injected startpage which can be disabled, but it works buggy in FF. But the main reason is that extension cannot inject iframe in startpage if it created by other extension or by default.
  3. Works for me. What browser you use?
  4. Accepted.
  5. not sure about this. Anyway first priority is to fix bugs. I will think about it later.
  6. Oo. I believe it because extension try to create fav icons for all of this bookmarks synchronically and it looks like "stuck". Need more experiments to check this theory. If you have time plz try to replace in "background.js" this line with
    newItem.domain = 'default';

@yfdyh000
Copy link
Contributor Author

Item 3: Firefox Nightly. "Add new RSS feed" button looks no effect, throw Error: Could not establish connection. Receiving end does not exist..
Well, I found the reason that it needs to load on the current page, you need to check the current page is not the privileged page (like about:addons) and use the notifications API to remind.

Item 6: Big improvement, just load takes a few seconds for the first start.

@yfdyh000
Copy link
Contributor Author

7: A plan to adding Add-ons management panel?

@yfdyh000
Copy link
Contributor Author

@zluca
Copy link
Owner

zluca commented Nov 27, 2017

Well, I found the reason that it needs to load on the current page, you need to check the current page is not the privileged page (like about:addons) and use the notifications API to remind.

It should open new tab if current page is privileged, i remember that it works before, but now for some reason it broken. I will look into this. :/

Item 6: Big improvement, just load takes a few seconds for the first start.

Ok, thx for testing. Now i have a clue.

Allow users to control which one is enabled or all disabled for each chrome_url_overrides properties.

It would be nice if they implement this functionality.

7: A plan to adding Add-ons management panel?

No. ( If I correctly understand what you mean. =) )

@zluca
Copy link
Owner

zluca commented Nov 28, 2017

@yfdyh000

  1. The bookmark panel is stuck when there are 10k bookmarks.

Can you tell me if it works better in latest version?

@yfdyh000
Copy link
Contributor Author

Can you tell me if it works better in latest version?

  1. 0.3.4. It takes many seconds when enableing, high CPU usage.
  2. If the bookmark panel is the last panel, it sometimes gets empty after it is enabled, Error: Could not establish connection. Receiving end does not exist. hundreds and the Search box's placeholder are undefined. Switch to another panel and switch back is work, switch back take about 2~5 seconds.
  3. Perhaps it is better to provides max result options? Such as show recent bookmarks only by default, max search results, max folders and sub-items, more... item to folder filter.

@zluca
Copy link
Owner

zluca commented Nov 28, 2017

0.3.4.

plz test 0.3.5. ^^

Error: Could not establish connection. Receiving end does not exist

Yep, annoying thing.

show recent bookmarks only by default

Good idea, it can work! Tomorrow i will try.

@yfdyh000
Copy link
Contributor Author

0.3.5 looks no changes. You can copy and paste several times to get a lot of bookmarks for testing.

@maverick74
Copy link
Contributor

in Firefox I'm missing:

Synced Tabs
Pocket List
ScreenShoots

(in short, the items that are presented on Library)

Do any of this stand a chance???

@zluca
Copy link
Owner

zluca commented Nov 29, 2017

@maverick74

Synced Tabs Pocket List

I need to make some research about this services. If they have good open API why not?

ScreenShoots

But why you need sidebar for making screenshots? There is a tons of extensions providing this feature.

@maverick74
Copy link
Contributor

maverick74 commented Nov 29, 2017

@zluca

about ScreenShots: i'm referring to the link/webpage that is open when one goes to Menu>Library>Screenshots https://screenshots.firefox.com/shots which contains one's screenshots, not the app to take screenshots.

Pocket List goes the same way: it's, apparently, just a webpage.

In another words, Pocket List and ScreenShots, from what i understand, is just supposed to be a link/webpage that is open in the sidebar.

On the other hand Synced Tabs, i believe, is an app and not a webpage.

@zluca
Copy link
Owner

zluca commented Nov 29, 2017

is just supposed to be a link/webpage

That's how it looks from user view. =) Screenshots and Pocket have a build-in extensions which doing the job invisibly for user.

From what i see Pocket is the main candidate to implement in next big release. But no promises. :)

@maverick74
Copy link
Contributor

LOL. It certainly looks pretty easy from where i stand. LOL

Looking forward for the improvements =)

@zluca
Copy link
Owner

zluca commented Dec 2, 2017

@yfdyh000

2: filled https://bugzilla.mozilla.org/show_bug.cgi?id=1420944
Priority: -- → P5

Ok, lets face the truth this is never happen. 😃
But users ask me so much about disabling startpage so i will do it.

@limon36
Copy link

limon36 commented Dec 27, 2017

yes because the all-in-one bar had it, the things on this list! But it had been disable due to the new firefox updates!

@herbstgy
Copy link

is it possible to set the refresh interval of the RSS feeds?

@zluca
Copy link
Owner

zluca commented Jan 15, 2018

@herbstgy
Options > Misc > RSS update period

@herbstgy
Copy link

@zluca
great, thx.

@EC-O-DE
Copy link

EC-O-DE commented Feb 25, 2018

Very good! Just what I was looking for (well vertical bookmarks bar (hover in/hover out)) but this seems promising. Worked in Opera without much glitch.

There's two ext's that u dev might find inspirational:
Bookmarks Sidebar: https://chrome.google.com/webstore/detail/bookmark-sidebar/jdbnofccmhefkmjbkkdkfiicjkgofkdh?hl=en-US
And:
vTabs: https://chrome.google.com/webstore/detail/vtabs/okpnlgbgcfchbicbhjmmhldhkbkfilce?hl=en-US

@edger78
Copy link

edger78 commented Mar 14, 2018

Open bookmark in new tab is really useful feature. Could you please implement it?

@zluca
Copy link
Owner

zluca commented Mar 14, 2018

@edger78
You should hold Ctrl button to open bookmark in new tab, or Shift to open in new window.

@edger78
Copy link

edger78 commented Mar 14, 2018

Yes, I know that, thanks, wheel click also works this way. But simple click is very welcome option. Not only me using that. Not sure if it's too complex to implement it.

@zluca
Copy link
Owner

zluca commented Mar 14, 2018

@edger78
Ok now i got it. This option would be implemented, but no ETAs, because i need to finish current development.

@edger78
Copy link

edger78 commented Mar 14, 2018

@zluca
Thanks, sure. Take your time :)
It's really great to have it finally.

@herbstgy
Copy link

Hi,
is it possible to somehow delete the older items in the RSS feed? they just keep piling up ever since I installed the addon. (which I love by the way)
image

@zluca
Copy link
Owner

zluca commented Mar 30, 2018

@herbstgy
Older rss items should be deleted automatically, there is an option in 'misc' section to set maximum items per feed. But for some reason it not work. Probably i broke something during last code refactor. Thx for reporting this bug.

@kenreeser
Copy link

kenreeser commented Sep 10, 2018

Sidebar+ is an excellent sidebar extension—well done zluca. To make it even better, I'd like like the ability to open all bookmarks contained within a bookmark folder simultaneously via a newly added icon added to each lowest level bookmark folder. I'm moving away from sessions and back to bookmarks because sessions aren't available on phones (because phone developers won't allow the use of browser extensions on mobile browsers). With the addition of my requested feature, I'll be able to treat folders of bookmarks more like sessions (sort of).

zluca added a commit that referenced this issue Sep 12, 2018
@zluca
Copy link
Owner

zluca commented Sep 15, 2018

@kenreeser
check out 0.5.16

@kenreeser
Copy link

kenreeser commented Sep 15, 2018

Excellent. Thank you very much. I tried to locate a donation link, but was unsuccessful. Please forward one to me.

Since finally getting past the setup phase with Chrome, I've been able to spend quite a bit of time with it. I have some more questions and ideas about Sidebar+. Is there any way to have the Iframe views remain open? I realize I can use windows, but I've found them very difficult to use—they don't open in the same locations and with the dimensions in which last left them. In addition, every time I move Chrome to a different screen (I have 3) I have to drag 3 objects instead of 1. Also, is there way I can totally disable Sidebar+'s start page? I have another favorite start page extension that crossed over from Firefox, but Sidebar+ keeps overriding it. And lastly, just as helpful as now being able to open a folder full of bookmarks at one time, it would be as helpful to be able to hold down a modified key such as Option (Alt on Windows) and click on any level bookmark folder and all bookmarks within that folder structure (all the way down) toggle between open and closed.

@zluca
Copy link
Owner

zluca commented Sep 15, 2018

I tried to locate a donation link, but was unsuccessful

Well, because there is none. I don't think it is worth it.

Is there any way to have the Iframe views remain open

Yep, there is "Pin" button at the top of sidebar.

Also, is there way I can totally disable Sidebar+'s start page?

Options > Services > Start page (uncheck it).

it would be as helpful to be able to hold down a modified...

Maybe. =)

@kenreeser
Copy link

kenreeser commented Sep 15, 2018

Well, I think it’s worth it. As a software developer, I’m a big believer in paying other developers for their time and creativity.

Unchecking the start page worked—looks like I missed that checkbox and was unchecking the empty start page checkbox instead—I have got to get some sleep

I really hope you're able to develop a modifier-key-click feature to open and close bookmark folder hierarchies en masse (i.e. whatever folder you click and all subfolders)—just closing all my hierarchical bookmark folders was a real chore. ;-)

@kenreeser
Copy link

Is there any way to have Sidebar+ Iframes appear when my tab page extension (New Tab Tools) opens its a new tab page?

@zluca
Copy link
Owner

zluca commented Sep 16, 2018

@kenreeser
Unfortunately there is no way and that actually why i maked my own startpage. WebExtension are isolated from each other in a sandboxes.

@kenreeser
Copy link

kenreeser commented Sep 17, 2018

Okay. So, I attempted a Chrome workaround for being able to view my Sidebar+ menus (1 on either side of my browser window) upon Chrome loading by sending Chrome to a specific page. Well, that didn't work. Upon loading chrome, it goes to the specified page, but my sidebar+ menus are not visible—as if I started up on a new tab page.

I believe I've concluded my Firefox Quantum vs. Chrome comparison. And, because of so many interface-related shortcomings in Chrome, I've decided to go back to Quantum. I really wanted to like and use Chrome because I believe it to be faster and better at utilizing memory than Quantum, but I also have to consider my workflow.

I installed Sidebar+ on Quantum (replaced Tree Tab Style extension, by the way—long time user). I like like the option to run Sidebar+ in the native window because it enables me to view Sidebar+ when I open a new tab page. I was wondering if Sidebar+'s Iframe menus could be made into split panes? I could have both my tabs and bookmarks viewable in the same left side menu in sizable and scrollable panes? And, perhaps more panes could be added.

Also, could the Sidebar+'s bookmark and bookmark folder movement interface become just like Firefox's native menu bookmark interface? I just attempted to move a single folder of bookmarks with Sidebar+ and now I have several hundred bookmark folders to close (one at a time)?

@kenreeser
Copy link

Oh, by the way, the mouse configuration dialog is extremely tiny (on both Chrome and Quantum).

zluca added a commit that referenced this issue Sep 17, 2018
@zluca
Copy link
Owner

zluca commented Sep 19, 2018

I was wondering if Sidebar+'s Iframe menus could be made into split panes?

It's require a lot of work, so no. For now im just fixing bugs and do some little enhancements.

I just attempted to move a single folder of bookmarks with Sidebar+ and now I have several hundred bookmark folders to close

Yep i'm agree hat this should be fixed, maybe some delay before folder opens.

@kenreeser
Copy link

How about only the hovered upon destination bookmark folder opens. And, if the a user changes their mind and wants to drag a bookmark item onto another destination, that prior destination bookmark folder closes and the next hovered upon destination opens. Actually, why can't this process work like the built-in bookmark managers in Firefox and Chrome?

@herbstgy
Copy link

herbstgy commented Oct 9, 2018

I was enthusiastic at first but it simply don't work.
I gave up after a half dozen uninstall and reinstall.
Autohide don't work. i lost my RSS feeds and can't put them back.

@zluca
Copy link
Owner

zluca commented Oct 9, 2018

@herbstgy
I have a bunch of reports like this one. Problem is that I can't reproduce. It is maybe something related to browser/OS and I personally don't see because of using Firefox on Linux (that a rare setup).

@herbstgy
Copy link

herbstgy commented Oct 9, 2018

@zluca
thank you for you positive answer despite of my negative comment.
I didn't want to degrade your work, I know you put your heart in it.
The thing is, I've gotten kinda dependent of this plugin and disappoints me that I can't use it. :)
I tried several times to uninstall and reinstall it to clean up. Now I'm trying an older version (0.5.15), and I guess I'm on something... I get back to you later.

@herbstgy
Copy link

herbstgy commented Oct 9, 2018

@zluca
I think I got it.
Sidebar+ always works for a short period of time after I reinstall it... Until I start fiddling with the settings to set it to my liking. :)
the problem is with this dialog window:
clipboard-1
I always try to set it up to open the favorites or the rss elements in a new tab in the browser. So, I set "Normal click" to "Open in new tab". ...And after that, the iFrame doesn't appear from the side anymore.

@herbstgy
Copy link

herbstgy commented Oct 9, 2018

To add some info to the earlier: I'm on Win 10 64 bit and Firefox 62.0.3 64 bit.
also, the extension I use:
image

@zluca
Copy link
Owner

zluca commented Oct 9, 2018

I always try to set it up to open the favorites or the rss elements in a new tab in the browser. So, I set "Normal click" to "Open in new tab". ...And after that, the iFrame doesn't appear from the side anymore.

Thx, now I have something to start with.

@herbstgy
Copy link

herbstgy commented Oct 9, 2018

I thought I have found the solution but after I restarted Firefox, autohide doesn't work again.
In iframe mode, if I move the mouse in the autohide activation area (the side of the window), nothing happens. If I click the mouse in the autohide activation area, it initiates drag, resizing the Sidebar. I can't click on the links.
If I turn Sidebar+ in native mode, I can see the sidebar and the links, but clicks on the links don't work. I can only open them with right click + Open in new tab.

@zluca
Copy link
Owner

zluca commented Oct 12, 2018

I can see the sidebar and the links, but clicks on the links don't work. I can only open them with right click + Open in new tab.

This mean background script is dead. I fixed one possible reason in 9519e16, but there still is a lot job to do.

@herbstgy
Copy link

ever tried to use SideBar+ and Firefox in multiple windows on multiple monitors?
I move the mouse to the side for SideBar to appear in iframe mode in one window, and SideBar appears in the other window. :)

@zluca
Copy link
Owner

zluca commented Nov 22, 2018

@herbstgy
I guess you hover sidebar on inactive window and its appears in active, is it?

@herbstgy
Copy link

it's the opposite, really. :)

@zluca
Copy link
Owner

zluca commented Dec 13, 2018

@herbstgy
Is 0.6.0 release make things better?

@herbstgy
Copy link

now:

  • if I open multiple Firefox widows, if I move the mouse to the side in the main (firstly opened) window, the sidebar appears in the right place.

  • if I move the mouse to the side in the secondly opened window, nothing happens. sidebar does not appear in neither window.

  • when I open a new instance of Firefox, an unwanted "New tab" appears beside the page I have opened, even if I turn off "Use custom startpage" option.

@zluca
Copy link
Owner

zluca commented Jan 2, 2019

@herbstgy
0.6.4 should fix iframe issues.

@yukon-cornelius
Copy link

Hello ... hope this suggestion list is still being monitored. :-)

Can a "reset settings" option please be added? I was playing with colors, and once I changed the border color (which also changed each section's color headings?) ... I couldn't get back. :-(

Also the settings are currently scattered around. There's sorting at the bottom, options from FF's add-ons screen, mouse actions from a button-click at the bottom, and position & community & link to options in the toolbar.

Putting a background image either on the sidebar or the new start page neither says what file is being used, nor does the background imaqe state (enabled/disabled, background image itself) seem to update even after "Save" is clicked.

Lastly the "Cancel" button in Options doesn't seem to do anything.

Just a lot of fit & finish & thoughts about usability, that's all. Thanks!

@zluca
Copy link
Owner

zluca commented Jul 8, 2020

@yukon-cornelius
Hello there. Active developing of this extension is frozen. Because the more experience i have the more clearly i understand that it was wrong architecture from the beginning. And i don't have enough courage (and time, and passion) to rewrite it from scratch as it meant to be. The only things i do now is small fixes.

Can a "reset settings" option please be added?

Ok.

Putting a background image...

Accepted.

Lastly the "Cancel" button in Options doesn't seem to do anything.

This button close floating "options dialog" window in Chromium based browsers. But in Firefox there is no dialog window so it is useless.

@maverick74
Copy link
Contributor

maverick74 commented Feb 2, 2022

Would be nice to have an option to "Open [page/link/bookmark] in sidebar" (Something like this: https://addons.mozilla.org/en-US/firefox/addon/open-link-in-sidebar/ ) - Just to avoid multiple extensions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants