Convert all Lint to CertificateLint #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zakird, I'm curious since you're a major maintainer here. Would you accept the formatting of the RegisterCertificateLint methods as is, or should I try to spend some more time getting the formatting just right? Also just curious, how do you feel about the fact that I ended up running gofumpt on all of these lints? |
|
Well, I actually think I have a correct solution in #767 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #765
Generation code: https://github.com/aaomidi/zlint-migration
The formatting isn't...what I exactly wanted it to be. I'm still trying to see if I can go directly to a well formatted struct and not have to run gofmpt on everything.
I've asked about the formatting issue: https://groups.google.com/g/golang-nuts/c/C16T4H7slA4