Skip to content

Commit

Permalink
[WIP][Kineto] Manual Submodule Update (pytorch#73090)
Browse files Browse the repository at this point in the history
Summary:
The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity.

This patch should bring Kineto back in sync on PyTorch CI.

Pull Request resolved: pytorch#73090

Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo.

Pulled By:
aaronenyeshi
aaronenyeshi

Reviewed By: briancoutinho

Differential Revision: D34230284

fbshipit-source-id: cbecaf79e51ad4b6d9cda9e855d839792a1c184b
  • Loading branch information
aaronenyeshi authored and facebook-github-bot committed Mar 5, 2022
1 parent 7e1b11c commit 2242352
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion third_party/kineto
Submodule kineto updated 170 files
5 changes: 0 additions & 5 deletions torch/csrc/autograd/profiler_kineto.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -549,12 +549,7 @@ struct KinetoThreadLocalState : public ProfilerThreadLocalStateBase {
auto iter = tidSeq2activity.find(key);
if (iter != tidSeq2activity.end()) {
libkineto::GenericTraceActivity* fwd = iter->second;
#ifdef USE_KINETO_UPDATED
fwd->flow.start = true;
#else
activity.flow.linkedActivity = fwd; // Only destination side set this,
// to distinguish with start side.
#endif
activity.flow.id = fwd->flow.id = fwd_bwd_link_id;
activity.flow.type = fwd->flow.type = libkineto::kLinkFwdBwd;
++fwd_bwd_link_id;
Expand Down

0 comments on commit 2242352

Please sign in to comment.