Skip to content

Commit

Permalink
[caffe] remove some unnecessary exported_preprocessor_flags (pytorch#…
Browse files Browse the repository at this point in the history
…80063)

Summary: Move caffe2 compiler flags out of exported_preprocessor_flags, these should only contain defines and includes.

Test Plan:
Flags before: P510631359
Flags after: P510631375

Removed compiler flags are not present in exported preprocessor flags any more and exported preprocessor flags are not duplicated in compiler flags:

{F745125320}

Reviewed By: smeenai

Differential Revision: D37288331

Pull Request resolved: pytorch#80063
Approved by: https://github.com/mehtanirav
  • Loading branch information
rmaz authored and pytorchmergebot committed Jun 22, 2022
1 parent 70be6f8 commit 58d7511
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions c2_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,6 @@ def get_c2_tvm():
return bool(int(c2_tvm))

_C2_XPLAT_NO_HPTT_PREPROCESSOR_FLAGS = [
"-fexceptions",
"-frtti",
"-Wno-shadow",
"-Wno-unknown-pragmas",
"-Wno-unused-variable",
"-Wno-sign-compare",
"-Icaffe2",
"-Imodules",
"-DEIGEN_NO_DEBUG",
Expand Down Expand Up @@ -139,7 +133,13 @@ def get_c2_xplat_preprocessor_flags():
def get_c2_xplat_no_hptt_compiler_flags():
return [
"-Os",
] + get_c2_xplat_no_hptt_preprocessor_flags()
"-fexceptions",
"-frtti",
"-Wno-shadow",
"-Wno-unknown-pragmas",
"-Wno-unused-variable",
"-Wno-sign-compare",
]

def get_c2_xplat_compiler_flags():
return get_c2_xplat_no_hptt_compiler_flags() + C2_XPLAT_HPTT_PREPROCESSOR_FLAGS
Expand Down

0 comments on commit 58d7511

Please sign in to comment.