Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on recent rubies #84

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Conversation

misdoro
Copy link

@misdoro misdoro commented Mar 30, 2020

Test on recent minor ruby versions,

  • add 2.7.0
  • allow failure on 2.3.8

@misdoro
Copy link
Author

misdoro commented Mar 30, 2020

@schneems I'm wondering if it would be better to migrate to github checks, something similar to what puma did: https://github.com/puma/puma/blob/master/.github/workflows/ruby.yml

WDYT ?

@schneems
Copy link
Member

@schneems I'm wondering if it would be better to migrate to github checks, something similar to what puma did: https://github.com/puma/puma/blob/master/.github/workflows/ruby.yml

I'm for it. I'm not in love with travis. I believe though that 2.3.8 isn't present or there's some issues with it in github actions. My preference is CircleCI these days.

2.3.8 is working now. Can you update your PR to not remove it?

@schneems schneems changed the base branch from master to main August 18, 2020 19:52
@misdoro
Copy link
Author

misdoro commented Aug 18, 2020

Updated

@schneems
Copy link
Member

thank you!

@schneems schneems merged commit bb38386 into zombocom:main Aug 25, 2020
@misdoro misdoro deleted the test_on_recent_rubies branch August 25, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants