Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #62 #71

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Fix #62 #71

merged 1 commit into from
Apr 6, 2019

Conversation

jacobkimmel
Copy link
Contributor

Fixes an error where some p-values are saved as str by checking if they can be cast to float then casting if so.
If not, a ValueError is raised.

This is probably not the best solution ("why are they str in the first place?") but it fixes the issue in a semi-sane way.

@jacobkimmel
Fix zqfang#62
9d8ffcd 
Fixes an error where some p-values are saved as `str` by checking if they can be cast to `float` then casting if so. If not, a `ValueError` is raised. This is probably not the best solution ("why are they `str` in the first place?") but it fixes the issue in a semi-sane way.
@zqfang zqfang merged commit 673e9ec into zqfang:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobkimmel @zqfang