Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MB AlbumArt search and changed to different http request library #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LeMS-Studio5
Copy link
Collaborator

Added MusicBrainz cover art ability and moved to a different HTTP library which can handle redirects (if a redirect occurred with the old library, it would not follow the redirect)

@johnnywolinger
Copy link

Can you upgrade this with spotify api album art and utf-8 char encode in album and artist name? Some albuns can't be readed because some artists have special chars like "ã, õ, ó, é, ê" on his names.

@by-lars
Copy link
Collaborator

by-lars commented Jan 21, 2023

Can you upgrade this with spotify api album art and utf-8 char encode in album and artist name? Some albuns can't be readed because some artists have special chars like "ã, õ, ó, é, ê" on his names.

I am working on a new version written in c# which directly loads Zune and hooks into the playback events. Sadly the discord API does not seems to support UTF-8 yet?

@johnnywolinger
Copy link

johnnywolinger commented Jan 21, 2023

Discord have, but your script in terminal show error message like this

Artist: Dubdogz, Bhaskar, Calmani & Grey, **S├®b** Mont (This is Séb),
Title: 100 Degrees
Album: 100 Degrees
<html><body><h1>400 Bad request</h1>
Your browser sent an invalid request.
</body></html>

And this invalid request is because have this special chars in some artists name. So when try to load, i got this message and art album and album name not showed correctly, album name show "unknow artist", maybe you have to create a way to convert this chars to show like a normal character encoded in utf-8.

@johnnywolinger
Copy link

A interesting feature its show a timer, of Zune application time opened. Showing a timer like 01:45:50 (HH:MM:SS) like Adobe RPC

@by-lars
Copy link
Collaborator

by-lars commented Feb 1, 2023

@johnnywolinger I implemented the timestamp feature in the new C# version. I will release a new binary in the coming days.

@by-lars
Copy link
Collaborator

by-lars commented Feb 1, 2023

@LeMS-Studio5 Sadly I can't merge your pull request, as I reimplemented everything in C# so that I can use the ZuneApis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants