-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use message box to fix #12 that was not solve in ctimer_db branch #16
Conversation
…ain/root keep running while prompt toplevel ask for reasons therefore the db entry might not capture the reasons.
…ite3 preinstalled.)
Right after complete step#6 I got
By manually creating a folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except #16 (comment) , the remaining of testing steps look good to me.
Data path Issue fixed. Ready for pull review. |
Hi, you pushed your db binary to the repository. |
Testing looks good. Thanks for the effort! |
(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)
Types of changes
Please put an
x
in the box that appliesDescription
The messages after a clock finishes are now prompt with tikinter default messagebox and simpledialog, solving the problem previously which the main window keep going while not waiting for response from subwindows.
Steps to Test This Pull Request
Steps to reproduce the behavior:
Expected behavior
Related Issue
#12 #6