update date every time when clock restart #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai271828
approved these changes
Jul 21, 2020
|
sounds good.
…On Tue, Jul 21, 2020 at 6:04 AM Taihsiang Ho ***@***.***> wrote:
***@***.**** approved this pull request.
The implementation is elegant. I like it very much.
not for this pull request: I smell some duplicated lines. Maybe we could a
function like refresh_widgets in the future pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH2QX2K3VRSHGY4LP4VETQTR4UHVLANCNFSM4PB6RLPA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)
Types of changes
Please put an
xin the box that appliesDescription
Describe what the change is
Previously the date on top of the clock is set once launched. Now the date is re-checked every time a clock finishes.
Steps to Test This Pull Request
Steps to reproduce the behavior:
I haven't think of a nice way of testing the desired behavior.