Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve general UI and UX #56

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Conversation

mheob
Copy link
Contributor

@mheob mheob commented Dec 8, 2020

Resolves #49

Proposed Changes

  • remove DETAILS buttons and link complete preview
  • hide unneeded navigation of post slideshow
  • increase the body text and line height a bit

@mheob mheob added bug Something isn't working enhancement New feature or request labels Dec 8, 2020
@mheob mheob added this to the 1.0 milestone Dec 8, 2020
@mheob mheob self-assigned this Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #56 (038e99a) into release/v1 (280d2ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/v1       #56   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files              19        18    -1     
  Lines             107       103    -4     
  Branches           33        33           
============================================
- Hits              107       103    -4     
Impacted Files Coverage Δ
src/components/Articles/FeaturedCarousel.tsx 100.00% <ø> (ø)
src/components/Articles/ArticlePreview.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280d2ab...c9623ec. Read the comment docs.

@mheob mheob changed the title WIP feat: improve general UI and UX feat: improve general UI and UX Dec 8, 2020
@mheob mheob marked this pull request as ready for review December 8, 2020 16:36
@mheob mheob merged commit e5a98ed into release/v1 Dec 8, 2020
@mheob mheob deleted the 49-ui--ux-modifications branch December 8, 2020 16:36
mheob added a commit that referenced this pull request Dec 8, 2020
* feat(article): increase the body text and line height a bit
* fix(article): hide unneeded navigation of post slideshow
* feat(article): remove DETAILS buttons and link complete preview

resolves #49
mheob added a commit that referenced this pull request Dec 9, 2020
* fix(home): display the pinned article only if pinned is selected (#53)
  fixes #52
* feat(settings): add a link to write email to convention team (#54)
* feat(settings): add a link to write an email to the convertion team
  resolves #51
* style: fix unused import of settingArray (from lgtm)
* feat(article): improve general UI and UX (#56)
* feat(article): increase the body text and line height a bit
* fix(article): hide unneeded navigation of post slideshow
* feat(article): remove DETAILS buttons and link complete preview
  resolves #49
* feat(home): improve the featured slider and sponsored preview (#59)
* feat(article): improve the sponsored by content
* feat(home): improve the content of the featured slider
  Move the title below the image and place the sponsored by content more prominent.
  resolves #43
* feat(app): add optimized app icons and splash screen (#60)
  resolves #41
* build: add the target as archive for iOS builds
mheob pushed a commit that referenced this pull request Dec 9, 2020
# [1.1.0](v1.0.0...v1.1.0) (2020-12-09)

### Bug Fixes

* **home:** display the pinned article only if pinned is selected ([#53](#53)) ([6391c83](6391c83)), closes [#52](#52)

### Features

* **app:** add optimized app icons and splash screen ([#60](#60)) ([a529a50](a529a50)), closes [#41](#41)
* **article:** improve general UI and UX ([#56](#56)) ([8934b7c](8934b7c)), closes [#49](#49)
* **home:** improve the featured slider and sponsored preview ([#59](#59)) ([b22e434](b22e434)), closes [#43](#43)
* **settings:** add a link to write email to convention team ([#54](#54)) ([280d2ab](280d2ab)), closes [#51](#51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant