Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home): improve the featured slider and sponsored preview #59

Merged
merged 5 commits into from
Dec 9, 2020

Conversation

mheob
Copy link
Contributor

@mheob mheob commented Dec 9, 2020

Resolves #43

Improvements

  • title moved under the picture
  • font family of the title is in serif-bold
  • horizontal padding fixed to match the 'normal' previews

Move the title below the image and place the sponsored by content more prominent.
Move the title below the image and place the sponsored by content more prominent.
@mheob mheob self-assigned this Dec 9, 2020
@mheob mheob added bug Something isn't working enhancement New feature or request labels Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #59 (063ae88) into release/v1 (8934b7c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/v1       #59   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files              18        18           
  Lines             103        96    -7     
  Branches           33        24    -9     
============================================
- Hits              103        96    -7     
Impacted Files Coverage Δ
src/components/Articles/ArticlePreview.tsx 100.00% <ø> (ø)
src/components/Articles/FeaturedCarousel.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8934b7c...063ae88. Read the comment docs.

@mheob mheob added this to the 1.0 milestone Dec 9, 2020
@mheob mheob merged commit b22e434 into release/v1 Dec 9, 2020
@mheob mheob deleted the 43-improve-sponsored-design branch December 9, 2020 19:13
mheob added a commit that referenced this pull request Dec 9, 2020
* fix(home): display the pinned article only if pinned is selected (#53)
  fixes #52
* feat(settings): add a link to write email to convention team (#54)
* feat(settings): add a link to write an email to the convertion team
  resolves #51
* style: fix unused import of settingArray (from lgtm)
* feat(article): improve general UI and UX (#56)
* feat(article): increase the body text and line height a bit
* fix(article): hide unneeded navigation of post slideshow
* feat(article): remove DETAILS buttons and link complete preview
  resolves #49
* feat(home): improve the featured slider and sponsored preview (#59)
* feat(article): improve the sponsored by content
* feat(home): improve the content of the featured slider
  Move the title below the image and place the sponsored by content more prominent.
  resolves #43
* feat(app): add optimized app icons and splash screen (#60)
  resolves #41
* build: add the target as archive for iOS builds
mheob pushed a commit that referenced this pull request Dec 9, 2020
# [1.1.0](v1.0.0...v1.1.0) (2020-12-09)

### Bug Fixes

* **home:** display the pinned article only if pinned is selected ([#53](#53)) ([6391c83](6391c83)), closes [#52](#52)

### Features

* **app:** add optimized app icons and splash screen ([#60](#60)) ([a529a50](a529a50)), closes [#41](#41)
* **article:** improve general UI and UX ([#56](#56)) ([8934b7c](8934b7c)), closes [#49](#49)
* **home:** improve the featured slider and sponsored preview ([#59](#59)) ([b22e434](b22e434)), closes [#43](#43)
* **settings:** add a link to write email to convention team ([#54](#54)) ([280d2ab](280d2ab)), closes [#51](#51)
@mheob
Copy link
Contributor Author

mheob commented Dec 9, 2020

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mheob mheob added the released label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant