-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix reading of multiple files with ROOTFrameReader (#417)
* Add documentation for opening of files API * Fix seg fault when reading from multiple files * Add tests and properly fix file switching * Ignore new test in sanitizer runs
- Loading branch information
Showing
5 changed files
with
143 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| #include "read_frame.h" | ||
|
|
||
| #include "podio/ROOTFrameReader.h" | ||
|
|
||
| int read_frames(podio::ROOTFrameReader& reader) { | ||
| if (reader.currentFileVersion() != podio::version::build_version) { | ||
| std::cerr << "The podio build version could not be read back correctly. " | ||
| << "(expected:" << podio::version::build_version << ", actual: " << reader.currentFileVersion() << ")" | ||
| << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| if (reader.getEntries("events") != 20) { | ||
| std::cerr << "Could not read back the number of events correctly. " | ||
| << "(expected:" << 20 << ", actual: " << reader.getEntries("events") << ")" << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| if (reader.getEntries("events") != reader.getEntries("other_events")) { | ||
| std::cerr << "Could not read back the number of events correctly. " | ||
| << "(expected:" << 20 << ", actual: " << reader.getEntries("other_events") << ")" << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| // Read the frames in a different order than when writing them here to make | ||
| // sure that the writing/reading order does not impose any usage requirements | ||
| for (size_t i = 0; i < reader.getEntries("events"); ++i) { | ||
| auto frame = podio::Frame(reader.readNextEntry("events")); | ||
| if (frame.get("emptySubsetColl") == nullptr) { | ||
| std::cerr << "Could not retrieve an empty subset collection" << std::endl; | ||
| return 1; | ||
| } | ||
| if (frame.get("emptyCollection") == nullptr) { | ||
| std::cerr << "Could not retrieve an empty collection" << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| processEvent(frame, (i % 10), reader.currentFileVersion()); | ||
|
|
||
| auto otherFrame = podio::Frame(reader.readNextEntry("other_events")); | ||
| processEvent(otherFrame, (i % 10) + 100, reader.currentFileVersion()); | ||
| // The other_events category also holds external collections | ||
| processExtensions(otherFrame, (i % 10) + 100, reader.currentFileVersion()); | ||
| } | ||
|
|
||
| if (reader.readNextEntry("events")) { | ||
| std::cerr << "Trying to read more frame data than is present should return a nullptr" << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| std::cout << "========================================================\n" << std::endl; | ||
| if (reader.readNextEntry("not_present")) { | ||
| std::cerr << "Trying to read non-existant frame data should return a nullptr" << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| // Reading specific (jumping to) entry | ||
| { | ||
| auto frame = podio::Frame(reader.readEntry("events", 4)); | ||
| processEvent(frame, 4, reader.currentFileVersion()); | ||
| // Reading the next entry after jump, continues from after the jump | ||
| auto nextFrame = podio::Frame(reader.readNextEntry("events")); | ||
| processEvent(nextFrame, 5, reader.currentFileVersion()); | ||
|
|
||
| // Jump over a file boundary and make sure that works | ||
| auto otherFrame = podio::Frame(reader.readEntry("other_events", 14)); | ||
| processEvent(otherFrame, 4 + 100, reader.currentFileVersion()); | ||
| processExtensions(otherFrame, 4 + 100, reader.currentFileVersion()); | ||
|
|
||
| // Jumping back also works | ||
| auto previousFrame = podio::Frame(reader.readEntry("other_events", 2)); | ||
| processEvent(previousFrame, 2 + 100, reader.currentFileVersion()); | ||
| processExtensions(previousFrame, 2 + 100, reader.currentFileVersion()); | ||
| } | ||
|
|
||
| // Trying to read a Frame that is not present returns a nullptr | ||
| if (reader.readEntry("events", 30)) { | ||
| std::cerr << "Trying to read a specific entry that does not exist should return a nullptr" << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| int main() { | ||
| auto reader = podio::ROOTFrameReader(); | ||
| reader.openFiles({"example_frame.root", "example_frame.root"}); | ||
| return read_frames(reader); | ||
| } |