Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading of multiple files with ROOTFrameReader #417

Merged
merged 5 commits into from
May 23, 2023

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented May 19, 2023

BEGINRELEASENOTES

  • Fix an issue with reading multiple files via the ROOTFrameReader (#411)
    • Add documentation for API of opening file(s)
    • Add tests for reading multiple files

ENDRELEASENOTES

  • Add tests covering this.

@tmadlener tmadlener linked an issue May 19, 2023 that may be closed by this pull request
@tmadlener
Copy link
Collaborator Author

The check of whether we switched TTrees inside the TChain had to be hoisted a level higher to make it possible to jump back again. The previous implementation implicitly relied on only moving forward. In that case checking that localEntry == 0 was enough to detect TTree changes.

@tmadlener tmadlener requested a review from hegner May 22, 2023 09:10
@tmadlener tmadlener merged commit fec8609 into AIDASoft:master May 23, 2023
@tmadlener tmadlener deleted the fix-multi-file-read branch May 23, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROOTFrameReader crash when reading multiple edm4hep files
2 participants