Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some minor issues with the Reader and Writer interfaces #618

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix some minor issues with the Reader and Writer interfaces #618

merged 3 commits into from
Jun 11, 2024

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Jun 6, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Fix minor issues with the Reader and Writer interface classes
    • Make sure that only the public API is public
    • Fix some const correctness issues by marking const methods as such
    • Remove unnecessary and (partially) unused APIs from the Writer interface
  • Remove the dictionary generation for podioIO as we don't need the dictionaries

ENDRELEASENOTES

@tmadlener tmadlener requested a review from jmcarcell June 6, 2024 14:34
@tmadlener tmadlener mentioned this pull request Jun 7, 2024
Open
3 tasks
@hegner hegner self-requested a review June 11, 2024 13:25
@hegner hegner merged commit 335a4ae into AIDASoft:master Jun 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner hegner approved these changes

@jmcarcell jmcarcell Awaiting requested review from jmcarcell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @hegner