Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip empty lines from ExtraCode includes to avoid some warnings during code generation #670

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Strip empty lines from ExtraCode includes to avoid some warnings during code generation #670

merged 2 commits into from
Sep 10, 2024

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Strip strings to avoid having empty includes from ExtraCode that would otherwise generate a warning during code generation.
  • Remove a debug printout from code generation

ENDRELEASENOTES

"Proper" fix for key4hep/EDM4hep#352

@tmadlener tmadlener mentioned this pull request Sep 10, 2024
Closed
jmcarcell
jmcarcell approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@jmcarcell jmcarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independently of this, some consistency with newlines (\n) in EDM4hep would be nice.

@tmadlener tmadlener merged commit d04229c into AIDASoft:master Sep 10, 2024
18 checks passed
@tmadlener tmadlener deleted the fix-include-empty branch September 10, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcarcell jmcarcell jmcarcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @jmcarcell