Remove endlines after the last include #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't something like this in podio - for include in (inc for inc in includes if inc):
+ for include in (inc for inc in includes if inc.strip()):be done? |
|
I agree with Andres approach here. This should be fixed in podio. However, I can't reproduce the issue locally for some reason. Is this still happening? Resp. is it OS / python version specific? |
|
Obsolete with AIDASoft/podio#670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a warning that was introduced in AIDASoft/podio#645 that appears when generating the EDM4hep files:
This happens because somewhere there is a
split('\n')and then one gets a line with one character.Some reestructuring (not having lines with a single ") are not needed but for consistency they are done as it is done in the rest of edm4hep.yaml.
BEGINRELEASENOTES
ENDRELEASENOTES