Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SAMG55 #1550

Closed
wants to merge 56 commits into from
Closed

Conversation

Parthasarathy
Copy link
Contributor

Added new Cortex M4 device.

* added template file for samd55j19
* added support for some test for gpio.
* added test support for serial flow control
* update in lp ticker apis.
* usticker file updated with latest source.
* updated gpio irq apis and added test for the same.
* updated files for KnR Coding Statndard.
* updated serial and usticker apis.
@Parthasarathy
Copy link
Contributor Author

The root cause of the issue I2C/SPI NVIC_SetVector not working was due to a issue in the target.json file in Mbed 3.0 the "user_irq_number: 50" was wrong it was fixed later.

Fixed, NVIC_SetVector works now.

@akhilpanayamparambil
Copy link
Contributor

Added test for I2C with AT30TSE75X (Temperature Sensor / EEPROM) in the test suite.

@Parthasarathy
Copy link
Contributor Author

Updated I2C master Slave test cases for SAMG55

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2016

This is adding async , can you please test those (share results), there are unit tests for spi, i2c, serial and lp ticker.

@akhilpanayamparambil
Copy link
Contributor

@0xc0170 We have not tested the peripherals with unit these unit test. We have tested them with out our own tests. Could you please suggest how to go forward.
Also meanwhile we shall try to test the peripherals with those tests too.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2016

@0xc0170 We have not tested the peripherals with unit these unit test. We have tested them with out our own tests. Could you please suggest how to go forward.
Also meanwhile we shall try to test the peripherals with those tests too.

This page explains cpptest with mbed library: https://developer.mbed.org/teams/SDK-Development/wiki/Mbed-SDK-cpputest-usage . Please read, and have a try to run some UTESTs.

Is there any other planned work on this PR?

@Parthasarathy
Copy link
Contributor Author

I think only the above unit testing is pending for this pull request.
Once it is done we will rebase it to master.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2016

I think only the above unit testing is pending for this pull request.

OK. let me know if any problems

@akhilpanayamparambil
Copy link
Contributor

@0xc0170 We are almost done with the testing. We have tested Serial and SPI for the Unit test provided and seems to work fine. We are now testing LPTicker. Once done, shall re base and let you know.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2016

@akhilpanayamparambil great news, please share the output from those tests (you can attach here the results from those tests)

@akhilpanayamparambil
Copy link
Contributor

For SPI
{{host_test_name;default_auto}}
{{description;Unit test}}
{{test_id;UT}}
{{start}}
TEST(SPI_Master_Asynchronous, queue_test) - 63 ms
TEST(SPI_Master_Asynchronous, short_tx_long_rx) - 29 ms
TEST(SPI_Master_Asynchronous, long_tx_short_rx) - 34 ms
TEST(SPI_Master_Asynchronous, long_tx_long_rx) - 30 ms
TEST(SPI_Master_Asynchronous, short_tx_short_rx) - 23 ms
TEST(SPI_Master_Asynchronous, 0_tx_nn_short_rx) - 35 ms
TEST(SPI_Master_Asynchronous, 0_tx_short_rx) - 64 ms
TEST(SPI_Master_Asynchronous, short_tx_0_rx_nn) - 87 ms
TEST(SPI_Master_Asynchronous, short_tx_0_rx) - 47 ms

OK (9 tests, 9 ran, 30 checks, 0 ignored, 0 filtered out, 514 ms)

@akhilpanayamparambil
Copy link
Contributor

For Serial
{{timeout;20}}
{{host_test_name;default_auto}}
{{description;Unit test}}
{{test_id;UT}}
{{start}}
TEST(Serial_Asynchronous, char_matching_with_complete) - 1 ms
TEST(Serial_Asynchronous, char_matching_failed) - 1 ms
TEST(Serial_Asynchronous, char_matching_success)
.././serial_asynch.cpp:238: error: Failure in TEST(Serial_Asynchronous, char_matching_success)
expected <90>
but was <91>
difference starts at position 1 at: < 91 >
^

  • 25 ms
    TEST(Serial_Asynchronous, rx_framing_error) - 3 ms
    TEST(Serial_Asynchronous, rx_parity_error) - 1 ms
    TEST(Serial_Asynchronous, long_tx_long_rx) - 2 ms
    TEST(Serial_Asynchronous, short_tx_short_rx) - 0 ms
    TEST(Serial_Asynchronous, short_tx_0_rx) - 1 ms

Errors (1 failures, 8 tests, 8 ran, 28 checks, 0 ignored, 0 filtered out, 75 ms)

{{failure}}
{{end}}

@akhilpanayamparambil
Copy link
Contributor

For LP Ticker
{{timeout;20}}
{{host_test_name;default_auto}}
{{description;Unit test}}
{{test_id;UT}}
{{start}}
TEST(LowPowerTimerTest, lp_ticker_deepsleep_wakeup_1ms_timeout) - 100 ms
TEST(LowPowerTimerTest, lp_ticker_deepsleep_wakeup_5sec_timeout) - 500 ms
TEST(LowPowerTimerTest, lp_ticker_callback_1ms_timeout) - 0 ms
TEST(LowPowerTimerTest, lp_ticker_callback_50us_timeout) - 0 ms
TEST(LowPowerTimerTest, lp_ticker_callback_2sec_timeout) - 200 ms

OK (5 tests, 5 ran, 9 checks, 0 ignored, 0 filtered out, 833 ms)

{{success}}
{{end}}

@akhilpanayamparambil
Copy link
Contributor

There are some changes to be pushed to the pull request. Shall incorporate all changes and re-base.

@Parthasarathy
Copy link
Contributor Author

I think all review comments are addressed. Thanks @0xc0170

Created new pull request after rebase
#1627

deepakvenugopal added a commit to deepakvenugopal/mbed-os that referenced this pull request Feb 9, 2018
…changes from c9bf20f..43c7ec2

43c7ec2 Merge branch 'release_internal' into release_external
ed76459 Merge pull request ARMmbed#1558 from ARMmbed/IOTTHD-2195
8d3bcb7 Add new function to unit tests
56f66a4 Review correction
8b7d018 Move indirect queue size public API to net_interface
d877c9e Review corrections
c25e476 Remove Eclipse project files for external release
d51f442 Merge branch 'release_internal' into release_external
135c48d Increase Thread SED buffer size for big packets
70931a7 Fix indirect queue packet ordering
10e51a4 API for changing Thread SED parent buffer size
6122d24 dereference null value issue fixed. (ARMmbed#1557)
d1378dc Clear IPv6 neighbor cache in partition change (ARMmbed#1554)
7610e91 Child neighbor entry updates (ARMmbed#1550)
c727295 cleared neighbours with child address that are not ours (ARMmbed#1549)
80b4d72 Thread partition merge mode TLV change (ARMmbed#1546)
edd7599 RLOC was updated before clearing child info (ARMmbed#1547)
a666056 router short address set to 0xfffe for non routers (ARMmbed#1543)
759ab05 delete route set and link set entries for a router ID (ARMmbed#1540)
23a1265 REED advertisement handling (Thread spec 5.16.3): (ARMmbed#1535)
0a32cb4 added active and pending timestamps to child update response (ARMmbed#1533)
d0eec80 Fix error case memory leak (ARMmbed#1537)
da9860f Pending set after link sync (ARMmbed#1526)
ffa1569 Thread router network data update after link sync (ARMmbed#1530)
3b46d8d Fix defects found by coverity (ARMmbed#1529)
3a57101 Fix compiler warnings and update traces (ARMmbed#1523)
c288227 Add extension check for partition weight drop in parent selection (ARMmbed#1521)
d8dea28 network data cleared after router forms new partition (ARMmbed#1525)
44a85e5 removed router flagging for thread_management_server file (ARMmbed#1524)
1cbced9 Merge pull request ARMmbed#1520 from ARMmbed/IOTTHD-2105_2
3d07365 Review corrections to network data clearing
22a0375 Clear network data from lost children
ffd8517 added a new thread management function (ARMmbed#1519)
80af9cb Thread BR network data clearing (ARMmbed#1518)
5a6f6b5 thread nvm valgrind uninitialized data fix (ARMmbed#1517)
d5e2198 Add API for partition weighting set (ARMmbed#1513)
8811d6f multicast forwarding scope changed and address registration updated. (ARMmbed#1516)
c277384 printf to tr_info (ARMmbed#1515)
bb21264 Thread combined nvm test (ARMmbed#1507)
76f7725 Primary BBR fixes from interop (ARMmbed#1512)
12ed5ab FHSS unit test: fixed fhss mac interface test (cherry picked from commit 805eb42e4416b00cc018dc32dceb353d0b6c8bb6)
dd21ea9 Remvoed unnecessary trace print's.
cb6e78b FHSS unit test: fixed fhss beacon tasklet test (cherry picked from commit abe6d671b058f4f069741eab24d51e4d62d550b0)
237b3d4 Fhss info print (ARMmbed#1486)
0f39a47 FHSS: Do not update synch monitor right after superframe change (cherry picked from commit 99d50ad9d7f8dad80f10c2a4303f4e75ab31a3c2)
c9a098f Fixed Timeoout force which actually never generate timeout.
957c7fb Pana server and client update:
ae230e5 FHSS: Update Beacon synch info in critical state
84bd8a4 FHSS: Synchronization must be done in critical state
fb1b163 Pan coordinator blacklist update
39fe6ba Added missing HAVE_RPL compiler flag
16a1bc5 MLE bootsrap and message timeout update
eeb2d39 enable BBR to support multicast registration in non   commercial networks (ARMmbed#1509)
4ea2bf8 uri modified. (ARMmbed#1510)
f443853 timeout corrected for neighbour entry (ARMmbed#1508)
ea93c1f Thread dev conf taken use (ARMmbed#1503)
5d5b239 bug fix in bbr start (ARMmbed#1505)
8dbd521 commented a trace. (ARMmbed#1504)
145dbdf device conf copy fix (ARMmbed#1502)
f60268f eid&random mac moved to device conf struct (ARMmbed#1497)
df18635 Let MAC choose address when mesh forwarding
42f916b fixed BBR stop to remove network data and routing information (ARMmbed#1500)
e058c2a pbbr changes (ARMmbed#1499)
1ece307 Merge pull request ARMmbed#1485 from ARMmbed/merge_release_back
dda8164 thread address handling updated. (ARMmbed#1496)
1dc21a1 thread extension fixes. (ARMmbed#1495)
543fe98 Merge branch 'release_internal'
bade70e Dua req changes (ARMmbed#1494)
1979df8 added status to MLR response and implemeted BMLR.ntf multicast. (ARMmbed#1492)
1807c01 mle class initialisation (ARMmbed#1488)
d809831 Merge pull request ARMmbed#1479 from ARMmbed/merge_release_to_master
bce812d Update license to Thread test file (ARMmbed#1483)
aaa4b1f Revert eclipse file removal

git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack
git-subtree-split: 43c7ec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants