Rebuild sources if configuration is changed #2177
Merged
+56
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a check for configuration data changes. If a change in configuration data is detected, all the sources in the tree are rebuilt. This is a fix for #2073. #2162 was originally proposed as a fix, but it was agreed that `--preinclude` is a more convenient way to include configuration data, since it can be used to change the behaviour of source files that don't include "mbed_config.h" directly, which is a big advantage when importing 3rd party source trees. Compared to #2162, this commit has the disadvantage of rebuilding all the source files if a configuration change is detected, but it was agreed that the advantage of using `--preinclude` outweighs the disadvantage of the increased compilation time.
|
LGTM |
JarkkoPaso
pushed a commit
to JarkkoPaso/mbed-os
that referenced
this pull request
Oct 7, 2019
…..0824752 0824752 Merge branch 'release_internal' into release_external f598339 Merge branch 'master' into release_internal 678e0fd Removed unicast RX flag set. it was affecting that we remove neighbor too early. a4317fc Corrected coding style cd2848e Added support for calculating the length of the TLS send message buffer f255931 Removed UDP echo msg data print and added source address print. adcca3d RPL dio config advertisment update 6db1f31 Merge pull request ARMmbed#2198 from ARMmbed/IOTTHD-3691 ad244d1 MAC: changed CCA and TX fail trace level to debug 496074a RPL parent select update: 32e22d3 MAC: Added trace to when CCA fails and packet TX is canceled 47b2e03 Corrected GKH initiation on supplicant c83423a PAE controller now removes keys from MAC on stop (ifdown) a6f98b7 Flagged extended key usage call with mbedTLS flags 0675a89 Added dynamic setting to enable certificate validation ff531d3 Added IDevID and LDevID certificate validation b30635f Merge pull request ARMmbed#2191 from ARMmbed/IOTTHD-3693 88019ec Updated message generated traces ea15b0e Remove all instances when domain is disbaled and clear EAPOL relay. dce25d3 Corrected security protocols init and security message routing 7b39e25 Do not trig Renew again after RPL parent registration done state. 3cad7bd DHCPv6 renew and transaction id update c5b6df3 DHCPv6 client update dea0d53 DHCPv6 client API update 5eaad10 Added missing address active flag init. 34c751b Corrected triggering of next GTK handshake on authenticator 4fad826 Corrected export keys callback parameters 26c10a6 SW MAC / 802.15.4 Frame counter per key support Update b62b120 Added robustness on DAO-ACK handling dfcebef Added support for new certificate modification functions fd4b2e9 WS ARO handler update e2d46b9 wi-sun neagtive ARO missing ACK update 443f03f Merge pull request ARMmbed#2181 from ARMmbed/IOTTHD-3530_2 f36da31 MAC: Update frame counter for asynch frames 3260fa1 Merge pull request ARMmbed#2177 from ARMmbed/IOTTHD-3530 f18052a MAC: Initialize frame counter with 0xffffffff 5453e5b MAC: Do not increment framecounter if security param init fails 5bd19c4 MAC: Do not update framecounter for fhss channel retry git-subtree-dir: features/nanostack/sal-stack-nanostack git-subtree-split: 0824752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check for configuration data changes. If a change in
configuration data is detected, all the sources in the tree are rebuilt.
This is a fix for #2073. #2162 was originally proposed as a fix, but it
was agreed that
--preincludeis a more convenient way to includeconfiguration data, since it can be used to change the behaviour of
source files that don't include "mbed_config.h" directly, which is a big
advantage when importing 3rd party source trees. Compared to #2162, this
commit has the disadvantage of rebuilding all the source files if a
configuration change is detected, but it was agreed that the advantage
of using
--preincludeoutweighs the disadvantage of the increasedcompilation time.