Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade render rework #3695

Merged

Conversation

covers1624
Copy link
Member

This has been in progress for some time but is finally ready. Basically, this is a complete rewrite of AE's Facade rendering. Myself and @yueh have been in discussion whilst this has been worked on so this isn't just a random PR out of the blue.

So what does this do and why?
AE's facade rendering was extremely simple, it polled the model it wanted to imitate and used the first available texture found, for most blocks this is fine and a adequate solution, where this solution fails is connected textures. This PR Addresses those issues, instead of polling for textures and building a new model, it simply 'slices' the model of the block into the facade shape, re interpolating textures and colours along the way, to do this it utilises a new pipeline i wrote for running multiple transformers across baked quads, its extremely fast and will spit the quad out in the same format that its piped in with, meaning that full bight blocks with CTM should render just fine, but due to the baked model pipeline in minecraft is about as efficient as it gets, Realistically Forge's lighting pipeline when rendering a chunk layer of Dense cables is slower than the pipeline slicing a chunk layer of Facades, in order for the system to get faster i need the ability to pipe each quad into forge's lighter.

Enough chit chat, Screenshots!
Connected textures work across TD Covers too!
(Chisel Block, AE facade, TD Cover, Chisel block)

Edge ZFighting was solved by 'kicking' the edges in.

But only kicking them in when needed.

Works perfectly with 'thin' facades.

Demonstrating that the pipeline respects VertexFormats, base edits to show controllers always active were used for this specifically for the screenshot.

Transparency issues are solved by shrinking the bounds of the transparent facade.

@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@AppliedEnergistics AppliedEnergistics deleted a comment from orod-org Aug 29, 2018
@yueh yueh changed the base branch from rv6-1.12 to facade-render-rework August 30, 2018 17:53
@yueh
Copy link
Member

yueh commented Aug 30, 2018

Merging into feature branch to potentially amend/squash (and hope it keeps the author as well as testing the new review service.

@yueh yueh merged commit 264893d into AppliedEnergistics:facade-render-rework Aug 30, 2018
@yueh yueh mentioned this pull request Aug 30, 2018
@Drullkus
Copy link

Drullkus commented Nov 1, 2018

I just heard about this! I’m so happy you guys pulled it off! :D

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants